Skip to content

i18n(ja): restore text dropped by the translation pipeline (part 2)#23316

Draft
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-fix-mt-dropped-text-2
Draft

i18n(ja): restore text dropped by the translation pipeline (part 2)#23316
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-fix-mt-dropped-text-2

Conversation

@yahonda

@yahonda yahonda commented Jul 21, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Follow-up to #23315, sweeping the same translation-pipeline damage outside the -anchored subset that PR covered.

The old MT pipeline numbered inline elements (code spans, links) before translating and sometimes failed to restore one, leaving a bare digit where the text belongs — often shuffling the surrounding spans too. The English source is intact; only the Japanese is damaged.

EN: The former command shows the states of all resources and data sources.
JA: コマンド 1 は、すべてのリソースとデータソースの状態を表示します。
->  前者のコマンドは、すべてのリソースとデータソースの状態を表示します。

327 lines across 208 files. This branch was rebuilt from i18n-ja-release-8.5 so the diff shows only this PR's own contribution; lines that #23315 or #23275 also touch are left to those PRs. Verified that the rebuild changes nothing about the end result: merging all fifteen ja PRs produces a byte-identical tree before and after.

This pass also covers a form the earlier detection missed entirely — a bare digit with no space after it (。1パラメータ\gc.max_write_bytes_per_sec`を使用するとfor EN "You can use thegc.max_write_bytes_per_secparameter"). 76 such lines were repaired. Two of them had lost real information:dm/dm-config-overview.md said 「1の最大長はsource-idです」 where the English is "The maximum length of source-idis **32**", andserverless-private-link-connection-to-amazon-msk.mdhad lost the "SASL" ofSASL/SCRAM`.

Several instances were carrying wrong technical information:

file was now
tiflash/tiflash-configuration.md ×2 値が 1 から[0.0, 1.0)の範囲 / [0.0, 1.0)から10000000000000の範囲 [0.0, 1.0)の範囲 — the invented bounds are not in the English
predicate-push-down.md 述語は…a < 1に簡略化されて TiKV にプッシュダウンされます プッシュダウンされることはありません — EN is "the predicate is not like case 2"; the old text also contradicted its own next sentence
faq/monitor-faq.md extraレプリカが不足していること 余分なレプリカが存在すること
tiflash/tiflash-alert-rules.md ×3 …から提供されました PingCAP またはコミュニティからサポートを受ける
transaction-overview.md 最大値はtxn-total-size-limitで、1 TB です txn-total-size-limitの最大値は 1 TB です
tune-tikv-thread-performance.md RaftstoreRaftstore数 Raftstoreスレッド

Also fixed, same pipeline, no digit involved: 7 occurrences of 「〜をビュー。」 (EN imperative "View X" left as a bare noun, not a sentence) — e.g. `TIDB_TRX`テーブルをビュー:`TIDB_TRX`テーブルを確認します:; and migrate-large-mysql-to-tidb.md where the file and directory spans were swapped (`metadata`ディレクトリにある`${data-path}`ファイル`${data-path}`ディレクトリにある`metadata`ファイル).

How it was checked

984 candidate sites were extracted, then every one was cross-checked against release-8.5 before editing — 760 turned out to be genuine numbers (「手順 3」,「16 進数」,「2 進対数スケール」, version/step/layer numbers, region and instance IDs) and were left untouched.

Mechanical verification of the result:

  • link targets: 0 added, removed or altered;
  • code spans: 0 invented — every code span introduced exists verbatim in the English source file;
  • doubled particles (をを/はは/がが/にに/でで/、、/。。): no increase over the base;
  • grep -r PLACEHOLDER: 0.

Scope note

Together with #23315 this closes the bare-digit defect class. The sweep repeatedly surfaced a different, pervasive artifact — a particle dropped right after a code span (`header`が`true`場合, `stream_count` 8 です) — which is only partially covered by #23272 / #23273 and would need its own pass.

This damage predates the current translation tooling, which has since been replaced, so it is a finite backlog rather than something that regenerates on each sync.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot

ti-chi-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2026
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1e8737d3-ff92-4b3d-a04c-3e6added0c05

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign overvenus for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added area/develop This PR relates to the area of TiDB App development. missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 21, 2026
@yahonda
yahonda force-pushed the i18n-ja-fix-mt-dropped-text-2 branch 2 times, most recently from af44097 to 99e79da Compare July 21, 2026 06:03
@yahonda
yahonda force-pushed the i18n-ja-fix-mt-dropped-text-2 branch from 99e79da to 6489514 Compare July 21, 2026 06:33
@yahonda
yahonda force-pushed the i18n-ja-fix-mt-dropped-text-2 branch 2 times, most recently from 3a92e84 to 3ac78e0 Compare July 21, 2026 07:08
@yahonda
yahonda force-pushed the i18n-ja-fix-mt-dropped-text-2 branch from 3ac78e0 to b643336 Compare July 21, 2026 07:19
Follow-up to pingcap#23315, covering the bare-digit artifacts outside the subset that PR
handled — including the form with no space after the digit (`。1パラメータ`), which
the earlier detection regex missed entirely.

The old MT pipeline numbered inline elements before translating and sometimes failed
to restore one, leaving a digit where the text belongs and shuffling the neighbouring
code spans. Each site was reconstructed from the English source on release-8.5.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@yahonda
yahonda force-pushed the i18n-ja-fix-mt-dropped-text-2 branch from b643336 to 93826e3 Compare July 21, 2026 08:19
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants