Double-click a sidebar thread row to rename#3064
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Minor UI enhancement adding double-click-to-rename for sidebar thread rows. Over 75% of the diff is test code; runtime changes are simple event handling that reuses existing rename functionality. You can customize Macroscope's approvability policy. Learn more. |
ba0abbd to
b02c392
Compare
|
Addressed both bot findings and rebased onto
Added a browser-test case for the input-bubbling regression; existing unit + browser tests still pass. |
b02c392 to
f76a272
Compare
f76a272 to
93cb1df
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 93cb1df. Configure here.
Double-clicking a thread row starts the existing inline rename, reusing the context-menu rename flow. - Plain double-click: the trailing click is ignored for navigation (guard runs after the cmd/shift branches, so multi-select still processes every click). - Modifier double-clicks (cmd/ctrl/shift/alt) stay multi-select intent and do not open rename. - Desktop-only: on mobile the first tap closes the sidebar sheet, so rename there stays on the context menu. - Double-clicks on the rename input, on nested controls (PR status, port, archive buttons), or on an already-renaming row no longer start/reset a rename. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
93cb1df to
9bd0a16
Compare

Double-clicking a thread row in the sidebar now starts the inline rename, reusing the existing context-menu rename flow (Enter commits, Esc cancels, blur commits). A
detail > 1guard stops the trailing click of a double-click from also navigating, so cmd/shift multi-select is unaffected.Tests
isTrailingDoubleClickcovers single / synthetic / double / triple clicks.🤖 Generated with Claude Code
Note
Low Risk
Sidebar interaction and rename UX only; existing commit path is reused and tests cover click/double-click edge cases.
Overview
Desktop sidebar thread rows can now be double-clicked to start the same inline rename flow as the context menu (Enter commits, Escape cancels, blur commits). Mobile is excluded so tap-to-navigate behavior stays unchanged.
The row wires
onDoubleClickwith guards for modifier keys (multi-select), nested buttons/links, and an in-progress rename. Clicks on the rename input stop propagation so word-select double-clicks do not reset the edit.startThreadRenameis extracted and passed intoSidebarThreadRowso context menu and double-click share one entry point.Navigation no longer runs on the second click of a double-click:
handleThreadClickbails whenisTrailingDoubleClick(event.detail)is true (after modifier-click handling).isTrailingDoubleClicklives inSidebar.logic.tswith unit tests; browser tests cover rename start, commit, cancel, and edge cases.SidebarThreadRowis exported for the new browser test file.Reviewed by Cursor Bugbot for commit 9bd0a16. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add double-click to rename a thread row in the sidebar
isTrailingDoubleClickutil in Sidebar.logic.ts, preventing unintended navigation when rename is triggered.Macroscope summarized 9bd0a16.