Add a Mill build script#269
Merged
Merged
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since
playframework/play-scala-seed.g8has been updated to support Mill 1.x, this PR introduces Mill build tool support to the current repository.Key Changes
The
build.millscript is largely identical to the upstream version, with two main differences:mill-versionConfiguration: Themill-versionis explicitly set in the build.verbatimConfiguration: Instead of usingphantomDeps, thebuild.millfile is simply added to the Giter8verbatimlist.Rationale & Design Decisions
1. Explicit
mill-versionExplicitly defining the
mill-versionis considered the better approach. Scala Steward should be fully capable of detecting and managing this version number automatically, just as it currently does forsbt.version.2. Avoiding
phantomDepsand$Escaping IssuesAdding
build.millto theverbatimlist bypasses the parsing confusion caused by the backslash-dollar (\$) escape sequence for both Scala Steward and Mill.Conveniently, since
build.millnow strictly acceptspackageas theRootModulename, we no longer need to engineer complex workarounds for Giter8 to process it dynamically.Future Work
If this approach proves successful and stable here, these two modifications can and should be contributed back to
playframework/play-scala-seed.g8.