Skip to content

remove floor tranform #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanyanzhu-pnnl merged 1 commit into from
Jun 27, 2026
Merged

remove floor tranform #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions comcheck_api/client/comcheck_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,19 +264,14 @@ def fill_empty_description(assemblies: list[dict]) -> list[dict]:
assembly["description"] = assembly.get("assemblyType")
return assemblies

def transform_floor(floors: list[dict]) -> list[dict]:
for floor in floors:
floor.pop('slabFullInsulBelowMinRValue', None)
return floors

# need to refactor this part to ensure the data integrity
reformatted_envelope_data = {
"agWall": fill_empty_description(envelope_data["agWall"]),
"roof": fill_empty_description(envelope_data["roof"]),
"skylight": fill_empty_description(envelope_data["skylight"]),
"window": fill_empty_description(envelope_data["window"]),
"door": fill_empty_description(envelope_data["door"]),
"floor": transform_floor(fill_empty_description(envelope_data["floor"]))
"floor": fill_empty_description(envelope_data["floor"])
}
assemblie_uvalue = self._service.assemblies_uvalue(reformatted_envelope_data, energy_code)
return assemblie_uvalue["data"]
Expand Down