refactor: introduce restore keys for cache - #14
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📜 Recent review details🧰 Additional context used🧠 Learnings (1)📚 Learning: 2026-05-11T16:19:49.450ZApplied to files:
🔇 Additional comments (1)
📝 WalkthroughWalkthrough
ChangesCache restore behavior
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoAdd restore keys for pnpm store cache fallback
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Add
restoreKeysfor restoring the store cache.The idea is that we currently include the
pnpm-lock.yamlcontent hash within the cache primary key. This means even if only one dependency has changed, the entirepnpm-lock.yamlcontent hash changes, and the entire pnpm store cache is now thrown away.But we don't have to invalidate the entire store. Other dependencies' cache may still be utilized. We can still restore the previous store cache, and only the changed dependencies need to be and will be downloaded.
restoreKeysdoesn't change the fact that the cache is still miss (primaryKey), so during the post action we still upload the latest pnpm store to a new cache entry.The PR is almost identical to pnpm/action-setup#280.
Summary by CodeRabbit