fix(vue-vapor): skip onFrame scheduling - #141
Merged
Merged
Conversation
Remove dynamic-prop detection and the onFrame call so primitive nodes no longer register per-frame callbacks, preventing unnecessary frame updates.
There was a problem hiding this comment.
Pull request overview
This PR updates the Vue Vapor component layer to stop scheduling per-frame onFrame() re-application for primitive nodes, relying on watchEffect() only to avoid unnecessary frame updates.
Changes:
- Removed dynamic-prop detection for primitive nodes (
createPrimitiveNode). - Removed
onFrame(apply)scheduling so primitive nodes no longer register per-frame callbacks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
235
to
246
| const apply = () => { | ||
| const extra = typeof opts.extra === "function" ? opts.extra() : (opts.extra ?? {}); | ||
| const next = { ...cleanProps(rawProps, omit), ...cleanExtraProps(extra) }; | ||
| for (const key of Object.keys(next)) setProp(node, key, next[key], prev[key]); | ||
| for (const key of Object.keys(prev)) { | ||
| if (!(key in next)) setProp(node, key, undefined, prev[key]); | ||
| } | ||
| prev = next; | ||
| assignRef(rawProps.nodeRef ?? rawProps.ref, node); | ||
| }; | ||
| const hasFrameDynamicProps = | ||
| typeof opts.extra === "function" || | ||
| Object.keys(rawProps).some((key) => !omit.has(key) && typeof rawProps[key] === "function"); | ||
| watchEffect(apply); | ||
| if (hasFrameDynamicProps) onFrame(apply); | ||
| return node; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove dynamic-prop detection and the onFrame call so primitive nodes no longer register per-frame callbacks, preventing unnecessary frame updates.