feat: remove private flag from @primer/react-canvas#8038
Open
joshblack wants to merge 1 commit into
Open
Conversation
|
joshblack
added
skip changeset
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes @primer/react-canvas publishable by removing its private flag, aligning it with the repo’s Changesets-driven release workflow so it can be released alongside other packages when versioned.
Changes:
- Removed
"private": truefrompackages/canvas/package.jsonto allow publication.
Show a summary per file
| File | Description |
|---|---|
| packages/canvas/package.json | Removes the private flag so the package can participate in normal publish workflows. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
1
to
4
| { | ||
| "name": "@primer/react-canvas", | ||
| "private": true, | ||
| "version": "0.0.2", | ||
| "type": "module", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the discussion up: https://github.com/github/planning-tracking/discussions/3426 it seems like this package is in a good shape to allow us to publish it when
@primer/reactitself is published 🥳This removes the private flag so that in the future when it receives changes it will be published as a part of our regular workflow.
Note: this does not include a changeset because
0.0.2is already published