refactor!: stop exporting StyleConfigurator and mxImageExport#3528
Merged
Conversation
StyleConfigurator and mxImageExport were exposed through the public entry points but are mxGraph implementation details that should not be part of the supported API surface. Removing them keeps the public API focused and avoids leaking mxGraph internals to consumers. The dev examples that relied on them now import StyleConfigurator from its internal path and call mxgraph.mxImageExport() directly. BREAKING CHANGE: - StyleConfigurator is no longer exported from the bpmn-visualization entry point. - mxImageExport is no longer re-exported from the mxgraph initializer.
tbouffard
added
the
chore
♻️ Preview destroyed
🤖 Powered by surge-preview |
|||||||||
♻️ Preview destroyed
🤖 Powered by surge-preview |
|||||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StyleConfigurator and mxImageExport were exposed through the public entry points but are mxGraph implementation details that should not be part of the supported API surface. Removing them keeps the public API focused and avoids leaking mxGraph internals to consumers.
The dev examples that relied on them now import StyleConfigurator from its internal path and call
mxgraph.mxImageExport() directly. This is not a breaking change as this export had never been released.
BREAKING CHANGE: