fix(scripts): compute bundle size KB with 1000 not 1024#3534
Merged
tbouffard merged 2 commits intoJun 24, 2026
Conversation
…cript Kilobyte (kB) is conventionally 1000 bytes in the context of file/bundle sizes, matching how npm and most bundler tools report sizes. Using 1024 was producing values in KiB, not kB, causing a mismatch with expected reporting units.
tbouffard
added
the
chore
|
tbouffard
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/list-npm-bundle-sizes.shfrom 1024 to 1000Test plan
npm run build-bundlesand thenbash scripts/list-npm-bundle-sizes.shto verify sizes are reported in kB (consistent with npm output)