refactor!: convert ShapeUtil from static-only class to object literal#3538
Merged
Conversation
ShapeUtil only ever held static methods, so modelling it as a class was misleading: it forced an eslint-disable for unicorn/no-static-only-class and let consumers reference it as a type or try to instantiate it. Exposing it as a plain object literal reflects what it actually is, a namespace of stateless utility functions, and removes the lint suppression. Every call site already uses ShapeUtil.method() access, so runtime behaviour and all internal usages are unchanged. The API remains experimental. BREAKING CHANGE: - ShapeUtil is now an object literal instead of a class. Calling its functions via ShapeUtil.method() is unchanged, but it can no longer be used as a type (e.g. `let u: ShapeUtil`), instantiated with `new ShapeUtil()`, or extended. This API is experimental.
♻️ Preview destroyed
🤖 Powered by surge-preview |
|||||||||
♻️ Preview destroyed
🤖 Powered by surge-preview |
|||||||||
tbouffard
added
the
skip CI e2e tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShapeUtil only ever held static methods, so modelling it as a class was misleading: it forced an eslint-disable for unicorn/no-static-only-class and let consumers reference it as a type or try to instantiate it. Exposing it as a plain object literal reflects what it actually is, a namespace of stateless utility functions, and removes the lint suppression.
Every call site already uses ShapeUtil.method() access, so runtime behaviour and all internal usages are unchanged. The API remains experimental.
BREAKING CHANGE:
let u: ShapeUtil), instantiated withnew ShapeUtil(), or extended. This API is experimental.