chore(deps-dev): bump playwright from 1.58.2 to 1.61.1#3539
Merged
Conversation
tbouffard
added
dependencies
♻️ Preview destroyed
🤖 Powered by surge-preview |
|||||||||
♻️ Preview destroyed
🤖 Powered by surge-preview |
|||||||||
…he new pw version
Update the macOS webkit failure thresholds from the e2e-webkit-test-results-macos-15 report. The new webkit engine on macos-15 produces larger label and font rendering diffs, so the reference thresholds no longer cover the observed differences and the tests fail on CI. Each threshold is set just above the observed diff (rounded up to 2 decimals) and its comment updated to the exact measured percentage. A new dedicated entry is added for group.02.in.collaboration.with.label, which previously relied on the webkit default. Several label/font related snapshots increased by more than 0.3 points (labels.01.general jumps from 1.79% to 4.65%), which likely reflects a real rendering change in the new engine rather than pixel noise. Also document the visual regression threshold mechanism and the report-driven update procedure in CLAUDE.md so the task can be reproduced.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the workaround in e2e tests workflow as the new playwright version correctly works when running with node 24.
Run workflow on macos-15 (previously macos-14) to run the test with an updated webkit browser.