fix(ci): read pnpm version from packageManager (fixes ERR_PNPM_BAD_PM_VERSION)#10
Merged
Merged
Conversation
ci.yml and test.yml pinned `version:` for pnpm/action-setup@v4 (9 and 9.12.0), conflicting with package.json's "packageManager": "pnpm@10.0.0" and failing every run with ERR_PNPM_BAD_PM_VERSION. Remove the pinned input so action-setup reads the version from packageManager. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI is failing on every run with:
ci.yml(version: 9) andtest.yml(version: 9.12.0) pinned a pnpm version forpnpm/action-setup@v4that conflicts withpackage.json's"packageManager": "pnpm@10.0.0". action-setup@v4 refuses the mismatch.These workflows were installed via the sh1pt
node-pnpm-ci/node-pnpm-testaction packs, which hardcoded the version. Root-cause fix for the packs: profullstack/sh1pt#720.Fix
Remove the pinned
version:input from both workflows so action-setup reads the version frompackageManager— the single source of truth.🤖 Generated with Claude Code