Skip to content

fix(commandboard): add body size limit and handle JSON parse errors (fixes #61) #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
Jun 14, 2026
+21 −2
Merged

fix(commandboard): add body size limit and handle JSON parse errors (fixes #61) #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions apps/commandboard-api/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,13 @@ async function route(request: IncomingMessage, response: ServerResponse) {
}

if (request.method === "POST" && url.pathname === "/api/plugins/c0mpute/jobs/dispatch") {
const body = await readJson(request);
let body: unknown;
try {
body = await readJson(request);
} catch {
json(response, 400, { error: "Invalid JSON body" });
return;
}
if (!isRecord(body) || typeof body.job_id !== "string") {
json(response, 422, { error: "Expected job_id" });
return;
Expand All @@ -277,7 +283,13 @@ async function route(request: IncomingMessage, response: ServerResponse) {
}

if (request.method === "POST" && url.pathname === "/api/plugins/c0mpute/quotes") {
const body = await readJson(request);
let body: unknown;
try {
body = await readJson(request);
} catch {
json(response, 400, { error: "Invalid JSON body" });
return;
}
if (!isRecord(body) || typeof body.workload !== "string") {
json(response, 422, { error: "Expected workload" });
return;
Expand Down Expand Up @@ -311,9 +323,16 @@ function text(response: ServerResponse, status: number, contentType: string, bod
response.end(body);
}

const MAX_BODY_BYTES = 1_048_576; // 1 MB

async function readJson(request: IncomingMessage) {
const chunks: Buffer[] = [];
let total = 0;
for await (const chunk of request) {
total += chunk.length;
if (total > MAX_BODY_BYTES) {
throw new Error("Request body too large");
}
chunks.push(Buffer.from(chunk));
}

Expand Down
Loading