Trim social follow action values by rissrice2105-agent · Pull Request #737 · profullstack/sh1pt

rissrice2105-agent · 2026-06-13T22:13:38Z

Closes #736.

Summary

Trim surrounding whitespace before normalizing sh1pt promote social follow --action values.
Add a regression assertion for " unfollow ".

Verification

corepack pnpm vitest run packages/cli/src/social-follow.test.ts
corepack pnpm --filter @profullstack/sh1pt typecheck (fails on existing workspace/module-resolution errors unrelated to this change: missing @profullstack/sh1pt-core, @profullstack/sh1pt-openapi/*, etc.)

greptile-apps · 2026-06-13T22:15:07Z

Greptile Summary

This PR fixes whitespace-padded --action values (' follow ', ' unfollow ') being incorrectly rejected by normalizeFollowAction. The fix is a one-character .trim() call inserted before .toLowerCase(), and a regression test for the ' unfollow ' case is added.

social-follow.ts: .trim() is applied to the action string before case-normalisation; the error message still reflects the original (untrimmed) user input, which is the correct UX.
social-follow.test.ts: New assertion normalizeFollowAction(' unfollow ') === 'unfollow' guards the fix; the symmetric ' follow ' case is not yet tested.

Confidence Score: 5/5

Safe to merge — the change is a single .trim() call that fixes an edge case without altering any other behaviour.

The fix is minimal and targeted: one method added to an existing chain, covered by a new test. The error message still exposes the original user input, which is correct. The only gap is a missing symmetric test for ' follow ', but the production code handles it correctly.

No files require special attention. social-follow.test.ts could benefit from a paired ' follow ' assertion, but this is a test-coverage gap rather than a defect.

Important Files Changed

Filename	Overview
packages/cli/src/social-follow.ts	Added `.trim()` before `.toLowerCase()` in `normalizeFollowAction` to strip surrounding whitespace from user-supplied `--action` values; no other logic changed.
packages/cli/src/social-follow.test.ts	Adds regression assertion for `' unfollow '` (padded with spaces) returning `'unfollow'`; existing cases are preserved.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["CLI: --action value"] --> B{"unfollow flag set?"}
    B -- yes --> C["return 'unfollow'"]
    B -- no --> D["action ?? 'follow'"]
    D --> E[".trim()"]
    E --> F[".toLowerCase()"]
    F --> G{"=== 'follow' or 'unfollow'?"}
    G -- yes --> H["return normalized value"]
    G -- no --> I["throw Error (shows original action)"]

_{Reviews (1): Last reviewed commit: "Trim social follow action values" | Re-trigger Greptile}

greptile-apps · 2026-06-13T22:15:11Z

+    expect(normalizeFollowAction(' unfollow ')).toBe('unfollow');
    expect(normalizeFollowAction('follow', true)).toBe('unfollow');


The new assertion covers ' unfollow ' (trimmed 'unfollow'), but the symmetric case ' follow ' (trimmed 'follow') is not tested. Since the trim now applies to both values equally, a paired assertion would make the coverage symmetric and guard against future regressions on the follow side.

Suggested change

expect(normalizeFollowAction(' unfollow ')).toBe('unfollow');

expect(normalizeFollowAction('follow', true)).toBe('unfollow');

expect(normalizeFollowAction(' unfollow ')).toBe('unfollow');

expect(normalizeFollowAction(' follow ')).toBe('follow');

expect(normalizeFollowAction('follow', true)).toBe('unfollow');

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

rissrice2105-agent · 2026-06-13T22:18:17Z

CI is green for PR #737.

Verification:

corepack pnpm vitest run packages/cli/src/social-follow.test.ts
corepack pnpm --filter @profullstack/sh1pt typecheck was attempted and still fails on existing workspace/module-resolution errors unrelated to this PR.

uGig invoice evidence has been sent for this PR.

github-actions · 2026-06-14T00:51:08Z