Skip to content

Sync CLI adapter registry with package directories#739

Merged
ralyodio merged 1 commit into
profullstack:masterfrom
rissrice2105-agent:codex/sh1pt-adapter-registry-sync
Jun 14, 2026
Merged

Sync CLI adapter registry with package directories#739
ralyodio merged 1 commit into
profullstack:masterfrom
rissrice2105-agent:codex/sh1pt-adapter-registry-sync

Conversation

@rissrice2105-agent

Copy link
Copy Markdown
Contributor

Closes #738.

Summary

  • Add existing litellm, specification-website, and posthog packages to the CLI adapter registry.
  • Expand the adapter registry test to verify every category against packages/<category>.
  • Preserve the intentional bots/core exclusion documented in the registry comment.

Verification

  • corepack pnpm vitest run packages/cli/src/adapter-registry.test.ts
  • corepack pnpm --filter @profullstack/sh1pt typecheck (fails on existing workspace/module-resolution errors unrelated to this change: missing @profullstack/sh1pt-core, @profullstack/sh1pt-openapi/*, etc.)

@greptile-apps

greptile-apps Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR syncs the CLI adapter registry with the filesystem by adding litellm (ai), specification-website (mcp-servers), and posthog (promo) to CATEGORIES, and expands the test from a single hard-coded targets check to a parameterised loop that validates every category against its packages/<category>/ directory.

  • litellm and specification-website are straightforward additions that match their respective package directories.
  • posthog is registered under promo ("Ad networks + fundraising rails"), but PostHog is a product-analytics platform; observability (which already holds sentry) is the more appropriate category.
  • The test refactor is a clear improvement — it now catches any future registry/filesystem divergence across all categories, not just targets.

Confidence Score: 3/5

Safe to merge for litellm and specification-website; posthog should be moved to observability before merge.

The registry and test changes are mechanically correct — arrays are sorted on both sides, the exclusion map preserves the bots/core carve-out, and the new packages all exist on disk. The one substantive concern is that posthog (a product-analytics tool) lands in promo, whose own description calls it "Ad networks + fundraising rails." This puts it in a category whose semantics actively conflict with what PostHog does, and the observability category already exists for exactly this kind of tooling.

packages/cli/src/adapter-registry.ts — specifically the promo adapter list where posthog was added.

Important Files Changed

Filename Overview
packages/cli/src/adapter-registry.ts Adds litellm to ai, specification-website to mcp-servers, and posthog to promo; posthog appears miscategorised (analytics ≠ ad network)
packages/cli/src/adapter-registry.test.ts Refactors single hard-coded targets test into a parameterised loop over all categories with an exclusion map for bots/core; logic is correct

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[adapter-registry.ts CATEGORIES] -->|ai| B[packages/ai/litellm ✅ added]
    A -->|mcp-servers| C[packages/mcp-servers/specification-website ✅ added]
    A -->|promo| D[packages/promo/posthog ⚠️ added — category mismatch?]
    A -->|observability| E[packages/observability/sentry — posthog fits here]

    F[adapter-registry.test.ts] -->|iterates CATEGORIES| G{for each category}
    G -->|reads packages/id/ dirs| H[sort + filter exclusions]
    H -->|compare| I{expect adapters == dirs}
    I -->|pass| J[✅ registry in sync]
    I -->|fail| K[❌ divergence detected]

    L[excludedPackageDirs] -->|bots/core| H
Loading

Reviews (1): Last reviewed commit: "Sync CLI adapter registry" | Re-trigger Greptile

pkgPrefix: '@profullstack/sh1pt-promo',
description: 'Ad networks + fundraising rails',
adapters: ['angellist', 'apple-search', 'capitalreach', 'google', 'kickstarter', 'linkedin', 'meta', 'microsoft', 'openvc', 'reddit', 'tiktok', 'wefunder', 'x', 'youtube'],
adapters: ['angellist', 'apple-search', 'capitalreach', 'google', 'kickstarter', 'linkedin', 'meta', 'microsoft', 'openvc', 'posthog', 'reddit', 'tiktok', 'wefunder', 'x', 'youtube'],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 posthog placed in promo rather than observability

PostHog is a product analytics and event-tracking platform, not an ad network or fundraising rail. The promo category description explicitly says "Ad networks + fundraising rails," while the observability category (which already holds sentry) is the natural home for analytics tooling. A user running sh1pt promo posthog would be surprised to find a product analytics adapter there, and future automation that filters by category description would silently misbehave.

@rissrice2105-agent

Copy link
Copy Markdown
Contributor Author

CI is green for PR #739.

Verification:

  • corepack pnpm vitest run packages/cli/src/adapter-registry.test.ts
  • corepack pnpm --filter @profullstack/sh1pt typecheck was attempted and still fails on existing workspace/module-resolution errors unrelated to this PR.

uGig invoice evidence has been sent for this PR.

@github-actions

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

4 similar comments
@github-actions

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@github-actions

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@github-actions

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@github-actions

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@ralyodio ralyodio merged commit 8746190 into profullstack:master Jun 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI adapter registry is missing existing adapter packages

2 participants