Sync CLI adapter registry with package directories#739
Conversation
Greptile SummaryThis PR syncs the CLI adapter registry with the filesystem by adding
Confidence Score: 3/5Safe to merge for The registry and test changes are mechanically correct — arrays are sorted on both sides, the exclusion map preserves the packages/cli/src/adapter-registry.ts — specifically the Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[adapter-registry.ts CATEGORIES] -->|ai| B[packages/ai/litellm ✅ added]
A -->|mcp-servers| C[packages/mcp-servers/specification-website ✅ added]
A -->|promo| D[packages/promo/posthog ⚠️ added — category mismatch?]
A -->|observability| E[packages/observability/sentry — posthog fits here]
F[adapter-registry.test.ts] -->|iterates CATEGORIES| G{for each category}
G -->|reads packages/id/ dirs| H[sort + filter exclusions]
H -->|compare| I{expect adapters == dirs}
I -->|pass| J[✅ registry in sync]
I -->|fail| K[❌ divergence detected]
L[excludedPackageDirs] -->|bots/core| H
Reviews (1): Last reviewed commit: "Sync CLI adapter registry" | Re-trigger Greptile |
| pkgPrefix: '@profullstack/sh1pt-promo', | ||
| description: 'Ad networks + fundraising rails', | ||
| adapters: ['angellist', 'apple-search', 'capitalreach', 'google', 'kickstarter', 'linkedin', 'meta', 'microsoft', 'openvc', 'reddit', 'tiktok', 'wefunder', 'x', 'youtube'], | ||
| adapters: ['angellist', 'apple-search', 'capitalreach', 'google', 'kickstarter', 'linkedin', 'meta', 'microsoft', 'openvc', 'posthog', 'reddit', 'tiktok', 'wefunder', 'x', 'youtube'], |
There was a problem hiding this comment.
posthog placed in promo rather than observability
PostHog is a product analytics and event-tracking platform, not an ad network or fundraising rail. The promo category description explicitly says "Ad networks + fundraising rails," while the observability category (which already holds sentry) is the natural home for analytics tooling. A user running sh1pt promo posthog would be surprised to find a product analytics adapter there, and future automation that filters by category description would silently misbehave.
|
CI is green for PR #739. Verification:
uGig invoice evidence has been sent for this PR. |
|
🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: |
4 similar comments
|
🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: |
|
🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: |
|
🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: |
|
🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: |
Closes #738.
Summary
litellm,specification-website, andposthogpackages to the CLI adapter registry.packages/<category>.bots/coreexclusion documented in the registry comment.Verification
corepack pnpm vitest run packages/cli/src/adapter-registry.test.tscorepack pnpm --filter @profullstack/sh1pt typecheck(fails on existing workspace/module-resolution errors unrelated to this change: missing@profullstack/sh1pt-core,@profullstack/sh1pt-openapi/*, etc.)