fix: stacker convert should include ENV vars into runtime config

[jmblatten]

Dockerfile ENV defines variables for both build and runtime. Stacker convert, converts ENV for build, but does not include runtime. Stacker uses "environment:" in yaml to define variables for runtime. So, include the ENV variables there so they will show up in the config when running the container.
See https://docs.docker.com/reference/dockerfile/#env

What type of PR is this?
bug

Which issue does this PR fix:
#757

What does this PR do / Why do we need it:
See above.

If an issue # is not available please add repro steps and logs showing the issue:
#757

Steps:

Dockerfile contents:
FROM alpine AS mybase
ENV HELLO=hello!
ENV GOODBYE=goodbye!
RUN echo $HELLO &&
echo $GOODBYE
Converted stacker.yaml
mybase:
build_env:
arch: amd64
from:
type: docker
url: docker://alpine
run:

• export HELLO=hello!
• export GOODBYE=goodbye!
• sh -e -c 'echo $HELLO && echo $GOODBYE'
  Using skopeo inspect
  "Env": [
  "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
  ]
  Note: env does not include HELLO and GOODBYE in image.

Testing done on this change:

CI
Manual:
Dockerfile contents:
FROM alpine AS mybase
ENV HELLO=hello!
ENV GOODBYE=goodbye!
RUN echo $HELLO &&
echo $GOODBYE
Converted stacker.yaml contents
mybase:
build_env:
arch: amd64
environment:
GOODBYE: goodbye!
HELLO: hello!
from:
type: docker
url: docker://alpine
run:

• export HELLO=hello!
• export GOODBYE=goodbye!
• sh -e -c 'echo $HELLO && echo $GOODBYE'
  Using skopeo inspect,
  "Env": [
  "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
  "GOODBYE=goodbye!",
  "HELLO=hello!"
  ]
  Automation added to e2e:
  None

Will this break upgrades or downgrades?
No

Does this PR introduce any user-facing change?:
Yes, but only for converted Dockerfiles. The resulting stacker.yaml file will now include an environment section if there were any ENVs in the Dockerfile. This will cause the image runtime to include the environment variables.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.92%. Comparing base (4583f3d) to head (0f83f57).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #782      +/-   ##
==========================================
+ Coverage   54.86%   54.92%   +0.05%     
==========================================
  Files          55       55              
  Lines        5909     5910       +1     
==========================================
+ Hits         3242     3246       +4     
+ Misses       2094     2093       -1     
+ Partials      573      571       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.