fix: allow non-mapping chunks in DataTree.chunk#11320
Open
SAY-5 wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
the
topic-DataTree
Match Dataset.chunk by accepting strings (e.g. "auto"), ints, and tuples/lists in DataTree.chunk, broadcasting the value to all dimensions of the tree. Previously any non-Mapping argument raised TypeError. Closes pydata#11315 Signed-off-by: SAY-5 <say.apm35@gmail.com>
Signed-off-by: SAY-5 <say.apm35@gmail.com>
SAY-5
force-pushed
the
fix/datatree-chunk-auto-11315
branch
from
c3a91d5 to
46c5196
Compare
Author
|
Rebased onto current main to resolve the merge conflict. Two kinds of pre-existing CI failures are showing:
Neither failure touches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Calling
DataTree.chunk("auto")(or with any non-mapping value such as an int) raisedTypeError: invalid type for chunks: <class 'str'>. Only mappings are supported, even though the type annotationT_ChunksFreqand the docstring both advertise that strings/ints/"auto"are valid.This brings
DataTree.chunkin line withDataset.chunk: a non-mapping value is broadcast across all tree dimensions,Noneemits aFutureWarninginstead of raising, and tuples/lists emit the same deprecation warning asDataset.Checklist
whats-new.rstapi.rst