fix(vend): scope OAuth UID by shop#1795
Open
nijel wants to merge 1 commit into
Open
Conversation
nijel
commented
Jun 17, 2026
Member
- Scope Vend social-auth UIDs with domain_prefix to prevent cross-shop numeric ID collisions.
- Validate and propagate domain_prefix through token/user data handling and stored extra data.
- Securely migrate legacy numeric associations only when their saved shop matches the current login.
- Add Vend regression tests and align storage UID typing/test indexes with string UIDs.
- Scope Vend social-auth UIDs with domain_prefix to prevent cross-shop numeric ID collisions. - Validate and propagate domain_prefix through token/user data handling and stored extra data. - Securely migrate legacy numeric associations only when their saved shop matches the current login. - Add Vend regression tests and align storage UID typing/test indexes with string UIDs.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1795 +/- ##
==========================================
+ Coverage 83.96% 84.15% +0.18%
==========================================
Files 341 342 +1
Lines 12155 12249 +94
Branches 579 589 +10
==========================================
+ Hits 10206 10308 +102
+ Misses 1742 1728 -14
- Partials 207 213 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.