Skip to content

fix(vend): scope OAuth UID by shop#1795

Open
nijel wants to merge 1 commit into
python-social-auth:masterfrom
nijel:vend
Open

fix(vend): scope OAuth UID by shop#1795
nijel wants to merge 1 commit into
python-social-auth:masterfrom
nijel:vend

Conversation

@nijel

@nijel nijel commented Jun 17, 2026

Copy link
Copy Markdown
Member
  • Scope Vend social-auth UIDs with domain_prefix to prevent cross-shop numeric ID collisions.
  • Validate and propagate domain_prefix through token/user data handling and stored extra data.
  • Securely migrate legacy numeric associations only when their saved shop matches the current login.
  • Add Vend regression tests and align storage UID typing/test indexes with string UIDs.

- Scope Vend social-auth UIDs with domain_prefix to prevent cross-shop numeric ID collisions.

- Validate and propagate domain_prefix through token/user data handling and stored extra data.

- Securely migrate legacy numeric associations only when their saved shop matches the current login.

- Add Vend regression tests and align storage UID typing/test indexes with string UIDs.
@nijel nijel self-assigned this Jun 17, 2026
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.52381% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.15%. Comparing base (673df79) to head (06fb442).

Files with missing lines Patch % Lines
social_core/backends/vend.py 72.22% 5 Missing and 5 partials ⚠️
social_core/tests/models.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1795      +/-   ##
==========================================
+ Coverage   83.96%   84.15%   +0.18%     
==========================================
  Files         341      342       +1     
  Lines       12155    12249      +94     
  Branches      579      589      +10     
==========================================
+ Hits        10206    10308     +102     
+ Misses       1742     1728      -14     
- Partials      207      213       +6     
Flag Coverage Δ
unittests 84.15% <89.52%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant