Skip to content

gh-150501: Fix various inspect.getattr_static documentation flaws, including in faulty code example attached#150504

Open
jonathandung wants to merge 2 commits into
python:mainfrom
jonathandung:patch-2
Open

gh-150501: Fix various inspect.getattr_static documentation flaws, including in faulty code example attached#150504
jonathandung wants to merge 2 commits into
python:mainfrom
jonathandung:patch-2

Conversation

@jonathandung
Copy link
Copy Markdown
Contributor

@jonathandung jonathandung commented May 27, 2026 •
edited
Loading

@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels May 27, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs May 27, 2026
@jonathandung jonathandung changed the title Fix various inspect.getattr_static documentation flaws, including in faulty code example attached gh-150501: Fix various inspect.getattr_static documentation flaws, including in faulty code example attached May 27, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 27, 2026
Open
picnixz
picnixz requested changes May 27, 2026
View reviewed changes
Comment thread Doc/library/inspect.rst
Comment thread Doc/library/inspect.rst Outdated
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 27, 2026

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented May 27, 2026 •
edited
Loading

Documentation build overview

📚 cpython-previews | 🛠️ Build #32867084 | 📁 Comparing ec3f4f5 against main (776573c)

  🔍 Preview build  

1 file changed
± library/inspect.html

@jonathandung jonathandung mentioned this pull request May 27, 2026
Open
@jonathandung
Copy link
Copy Markdown
Contributor Author

jonathandung commented May 27, 2026

I have made the requested changes; please review again

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 27, 2026

Thanks for making the requested changes!

@picnixz: please review the changes made to this pull request.

@bedevere-app bedevere-app Bot requested a review from picnixz May 27, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz Awaiting requested review from picnixz

Assignees

No one assigned

Labels

awaiting change review docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonathandung @picnixz