Skip to content

gh-154200: Use sysconfig.get_platform() in test_importlib.test_windows #154210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SynaptSea wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −20
Open

gh-154200: Use sysconfig.get_platform() in test_importlib.test_windows #154210

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d63344e
gh-154200: Use sysconfig.get_platform() in test_importlib.test_windows
SynaptSea Jul 20, 2026
0cb4a36
Merge branch 'main' into fix-test-windows-platform
chris-eibl Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions Lib/test/test_importlib/test_windows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import os
import re
import sys
import sysconfig
import unittest
from test import support
from test.support import import_helper
Expand All @@ -17,25 +18,6 @@
EnumKey, CloseKey, DeleteKey, OpenKey
)

def get_platform():
# Port of distutils.util.get_platform().
TARGET_TO_PLAT = {
'x86' : 'win32',
'x64' : 'win-amd64',
'arm' : 'win-arm32',
}
if ('VSCMD_ARG_TGT_ARCH' in os.environ and
os.environ['VSCMD_ARG_TGT_ARCH'] in TARGET_TO_PLAT):
return TARGET_TO_PLAT[os.environ['VSCMD_ARG_TGT_ARCH']]
elif 'amd64' in sys.version.lower():
return 'win-amd64'
elif '(arm)' in sys.version.lower():
return 'win-arm32'
elif '(arm64)' in sys.version.lower():
return 'win-arm64'
else:
return sys.platform

def delete_registry_tree(root, subkey):
try:
hkey = OpenKey(root, subkey, access=KEY_ALL_ACCESS)
Expand Down Expand Up @@ -143,7 +125,7 @@ def test_tagged_suffix(self):
suffixes = self.machinery.EXTENSION_SUFFIXES
abi_flags = "t" if support.Py_GIL_DISABLED else ""
ver = sys.version_info
platform = re.sub('[^a-zA-Z0-9]', '_', get_platform())
platform = re.sub('[^a-zA-Z0-9]', '_', sysconfig.get_platform())
expected_tag = f".cp{ver.major}{ver.minor}{abi_flags}-{platform}.pyd"
try:
untagged_i = suffixes.index(".pyd")
Expand Down
Loading