gh-154225: Fix os.openpty() acquiring a controlling terminal on Solaris#154229
Merged
serhiy-storchaka merged 2 commits intoJul 20, 2026
Conversation
… Solaris Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
serhiy-storchaka
added
needs backport to 3.13
serhiy-storchaka
enabled auto-merge (squash)
July 20, 2026 08:22
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-154238 is a backport of this pull request to the 3.15 branch. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
bedevere-app
Bot
removed
the
needs backport to 3.15
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 20, 2026
|
GH-154256 is a backport of this pull request to the 3.14 branch. |
|
GH-154257 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 20, 2026
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On illumos/Solaris the
ptemSTREAMS module pushed byos.openpty()makes the slave a terminal, which a session leader without a controlling terminal then acquires despiteO_NOCTTY. This hangs the pty-based test cluster underpython -m test -jN(regrtest workers are session leaders). Disown a newly-acquired controlling terminal withTIOCNOTTY. Verified on illumos: the cluster passes in workers, normalopenpty()still returns a working tty, and a pre-existing controlling terminal is left untouched.🤖 Generated with Claude Code