Skip to content

[3.13] gh-154225: Fix os.openpty() acquiring a controlling terminal on Solaris (GH-154229) #154257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 1 commit into from
Jul 20, 2026
+21 −0
Merged

[3.13] gh-154225: Fix os.openpty() acquiring a controlling terminal on Solaris (GH-154229) #154257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2026-07-20-14-10-00.gh-issue-154225.openpty.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix :func:`os.openpty` on Solaris and illumos: it no longer leaves the
pseudo-terminal as the controlling terminal of the calling process.
19 changes: 19 additions & 0 deletions Modules/posixmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8863,11 +8863,30 @@ os_openpty_impl(PyObject *module)
goto posix_error;

#if !defined(__CYGWIN__) && !defined(__ANDROID__) && !defined(HAVE_DEV_PTC)
// Pushing "ptem" makes the slave a terminal, which a session leader
// without a controlling terminal then acquires as one despite O_NOCTTY.
// Note whether we already had one, so a new one can be disowned below.
int had_ctty = 0;
#ifdef TIOCNOTTY
int tty_fd = open("/dev/tty", O_RDONLY | O_NOCTTY);
if (tty_fd >= 0) {
had_ctty = 1;
close(tty_fd);
}
#endif
ioctl(slave_fd, I_PUSH, "ptem"); /* push ptem */
ioctl(slave_fd, I_PUSH, "ldterm"); /* push ldterm */
#ifndef __hpux
ioctl(slave_fd, I_PUSH, "ttcompat"); /* push ttcompat */
#endif /* __hpux */
#ifdef TIOCNOTTY
if (!had_ctty && getsid(0) == getpid()) {
// Disown it; TIOCNOTTY sends SIGHUP to the session leader.
PyOS_sighandler_t sig_saved = PyOS_setsig(SIGHUP, SIG_IGN);
ioctl(slave_fd, TIOCNOTTY);
PyOS_setsig(SIGHUP, sig_saved);
}
#endif
#endif /* HAVE_CYGWIN */
#endif /* HAVE_OPENPTY */

Expand Down