gh-154335: Allow disabling terminal colors in Tachyon's pstats_collector module#154344
Open
pfackeldey wants to merge 2 commits into
Open
gh-154335: Allow disabling terminal colors in Tachyon's pstats_collector module#154344pfackeldey wants to merge 2 commits into
pstats_collector module#154344pfackeldey wants to merge 2 commits into
Conversation
…gh environment variables
|
All commit authors signed the Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses
_colorize.get_colors()instead of the_colorize.ANSIColorsenum. That way, one can disable terminal coloring through ANSI escape codes with e.g. setting certain env vars, such asNO_COLOR=1.I couldn't find an appropriate place for a test (and also I wasn't sure what's the best way to test this). Please let me know what your preference is regarding a test, and I'm happy to add it.
pstats_collectordoes not respect "no-color" modes #154335