Add zizmor to pre-commit and fix findings#1812
Open
hugovk wants to merge 3 commits into
Open
Conversation
Comment on lines
+15
to
+16
| # Cooldowns protect against supply chain attacks by avoiding the | ||
| # highest-risk window immediately after new releases. |
Member
There was a problem hiding this comment.
I don't like the false sense of security this gives us, this comment makes this seem fail-safe.
Member
Author
There was a problem hiding this comment.
It's a copy-paste from python/cpython#141866 which references https://blog.yossarian.net/2025/11/21/We-should-all-be-using-dependency-cooldowns.
Nothing is fail-safe in security, there are many things we can do to protect against these attacks, and this is a good one. They layer on top of each other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow on from #1811.
Add zizmor to pre-commit and fix findings.
Update other pre-commit hooks.
Add handy env vars:
FORCE_COLOR: 1RUFF_OUTPUT_FORMAT: githubReplace pre-commit with prek to remove Node.js 20 deprecation warning and unpinned transitive dependencies.