Reject direct union expressions in Literal#21540
Open
97littleleaf11 wants to merge 2 commits into
Open
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: xarray (https://github.com/pydata/xarray)
+ xarray/core/groupby.py: note: In member "_first_or_last" of class "GroupBy":
+ xarray/core/groupby.py:1461: error: Parameter 1 of Literal[...] cannot be a union expression [valid-type]
+ xarray/core/groupby.py: note: At top level:
|
97littleleaf11
commented
May 26, 2026
| from typing import Literal as L, Optional as O, Union as U | ||
|
|
||
| a: Literal[1 | None] # E: Parameter 1 of Literal[...] cannot be a union expression | ||
| b: Literal[1 | 2] # E: Parameter 1 of Literal[...] cannot be a union expression |
Collaborator
Author
There was a problem hiding this comment.
bad case of error msg here. 1 | 2 should be recongized as bitwise operation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17260
A union expression inside Literal[...] should not be valid, e.g. Literal[1 | None] or Literal[Union[Literal[1], None]].
Remaining issues to discuss, cc @JukkaL :