Fix TypedDict closed argument version check#21749
Open
vetrovk wants to merge 4 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
A5rocks
suggested changes
Jul 20, 2026
A5rocks
left a comment
A5rocks
left a comment
Collaborator
There was a problem hiding this comment.
Sorry but this change doesn't really work. And as mentioned in the issue, this should be allowed in stub files/typing only sections.
Please do not respond with LLM-generated comments, or I will assume you are putting no work into this PR and close it.
A5rocks
reviewed
Jul 20, 2026
| base_fullname = defn.base_type_exprs[0].fullname | ||
|
|
||
| is_closed: bool | None = None | ||
| if "closed" in defn.keywords: |
Collaborator
There was a problem hiding this comment.
Why can't you do the check here...?
This comment has been minimized.
This comment has been minimized.
Author
|
Thanks for the review. The issue is now addressed. |
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: altair (https://github.com/vega/altair)
+ altair/vegalite/v6/schema/_config.py:6593: error: "closed" argument to TypedDict is only available in Python 3.15 and later [misc]
+ altair/vegalite/v6/schema/_config.py:6618: error: "closed" argument to TypedDict is only available in Python 3.15 and later [misc]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closedargument ontyping.TypedDictwhen targeting Python versions below 3.15.typing_extensions.TypedDicton older Python versions.Details
PEP 728 adds the
closedargument to the standard-libraryTypedDictin Python 3.15. Mypy previously accepted the argument for earlier target versions and applied closed TypedDict semantics without reporting that the runtime API was unavailable.This change adds a semantic version check specifically for
typing.TypedDict. Bothclosed=Trueandclosed=Falseare rejected below Python 3.15, while the backport intyping_extensionsremains supported.Tests
python runtests.py check-typeddictpython -m pytest -n0 mypy/test/testcheck.py -k TypedDictpython runtests.py lintFixes #21747
AI-assisted: tooling was used during investigation and implementation; the contributor reviewed and validated the final patch.