Ignore failing buildbots that last ran over 14 days ago#415
Open
hugovk wants to merge 1 commit into
Open
Conversation
savannahostrowski
approved these changes
Jul 21, 2026
savannahostrowski
left a comment
savannahostrowski
left a comment
Member
There was a problem hiding this comment.
Overall, LGTM.
Maybe we could also print out "ignoring N stale builders" or something in check_buildbots as well?
| JSON = dict[str, Any] | ||
|
|
||
| # Builders whose most recent build was more than this many days ago | ||
| # are considered inactive and ignored when checking for failures |
Member
There was a problem hiding this comment.
Suggested change
| # are considered inactive and ignored when checking for failures | |
| # are considered inactive and ignored when checking for failures |
| ("tests/buildbotapi/success.json", False), | ||
| ("tests/buildbotapi/failure.json", True), | ||
| ("tests/buildbotapi/no-builds.json", False), | ||
| # Recent builds: judged on their result |
Member
There was a problem hiding this comment.
Maybe we can add a case for the cutoff (i.e. FAILURE_COMPLETE_AT + 14 * DAY)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #410.