Arm backend: Relocate not-equal decomposition after rank matching#19769
Open
Sebastian-Larsson wants to merge 1 commit into
Open
Arm backend: Relocate not-equal decomposition after rank matching#19769Sebastian-Larsson wants to merge 1 commit into
Sebastian-Larsson wants to merge 1 commit into
Conversation
Move DecomposeNotEqualPass to the post scalar-removal node transformation block. This removes its special placement between ReplaceScalarWithTensorByProfilePass and MatchArgRanksPass. Also match ranks for ne.Tensor before decomposition so scalar not-equal does not produce mismatched TOSA EQUAL operands. Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com> Change-Id: I131e617a4625f5cd9c28c553af44cd2276803d94
Sebastian-Larsson
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19769
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
zingo
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move DecomposeNotEqualPass to the post scalar-removal node transformation block. This removes its special placement between ReplaceScalarWithTensorByProfilePass and MatchArgRanksPass.
Also match ranks for ne.Tensor before decomposition so scalar not-equal does not produce mismatched TOSA EQUAL operands.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @robell @rascani