merge fbcode-only TARGETS rules into existing targets.bzl files (#21145) by bigfootjon · Pull Request #21145 · pytorch/executorch

bigfootjon · 2026-07-22T17:40:13Z

Summary:

Chunk 7B of fbcode/executorch TARGETS->BUCK migration. 5 directories where
both a TARGETS file (with extra fbcode-only rules) and a targets.bzl
existed. For each:

Added the new fbcode-only loads from TARGETS to the top of targets.bzl
(deduped against already-present loads).
Updated def define_common_targets(...) to accept is_fbcode = False.
Appended the fbcode-only TARGETS body at the end of the function inside
an if is_fbcode: block so xplat continues to skip those rules.
Replaced TARGETS with a thin BUCK calling
define_common_targets(is_fbcode = is_fbcode()).

Directories migrated:

backends/cortex_m/test
examples/models/llama/fb
examples/qualcomm/oss_scripts/llama
examples/qualcomm/oss_scripts/whisper
kernels/fb/custom_ops

Reviewed By: mzlee

Differential Revision: D109082046

pytorch-bot · 2026-07-22T17:40:17Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21145

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit eecb716 with merge base fbd14e6 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2026-07-22T17:40:47Z

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109082046.

github-actions · 2026-07-22T17:41:40Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot

Pull request overview

Migrates fbcode-only Buck TARGETS rules into the corresponding targets.bzl files (with an is_fbcode gate) and replaces TARGETS with thin BUCK wrappers that call define_common_targets(is_fbcode = is_fbcode()), supporting the ongoing TARGETS→BUCK migration while keeping xplat behavior unchanged.

Changes:

Introduces/updates define_common_targets(is_fbcode = False) and gates fbcode-only rules behind if is_fbcode.
Replaces legacy TARGETS files with BUCK wrappers that call into targets.bzl.
Adds required fbcode-only loads to targets.bzl where needed.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
test/end2end/targets.bzl	New fbcode-gated target definitions migrated from `TARGETS`.
test/end2end/TARGETS	Removed; content migrated into `targets.bzl`.
test/end2end/BUCK	Now calls `define_common_targets(is_fbcode = is_fbcode())`.
exir/tests/targets.bzl	New fbcode-gated test/library targets migrated from `TARGETS`.
exir/tests/TARGETS	Removed; content migrated into `targets.bzl`.
exir/tests/BUCK	Now calls `define_common_targets(is_fbcode = is_fbcode())`.
exir/dialects/edge/test/targets.bzl	New fbcode-gated test targets migrated from `TARGETS`.
exir/dialects/edge/test/TARGETS	Removed; content migrated into `targets.bzl`.
exir/dialects/edge/test/BUCK	Now calls `define_common_targets(is_fbcode = is_fbcode())`.
examples/qualcomm/oss_scripts/whisper/targets.bzl	Adds `is_fbcode` gating for fbcode-only Python targets; keeps OSS targets unconditional.
examples/qualcomm/oss_scripts/whisper/TARGETS	Removed; content migrated into `targets.bzl`.
examples/qualcomm/oss_scripts/whisper/BUCK	Now calls `define_common_targets(is_fbcode = is_fbcode())`.
examples/qualcomm/oss_scripts/llama/targets.bzl	Adds `is_fbcode` gating for fbcode-only Python targets/aliases; keeps OSS targets unconditional.
examples/qualcomm/oss_scripts/llama/TARGETS	Removed; content migrated into `targets.bzl`.
examples/qualcomm/oss_scripts/llama/BUCK	Now calls `define_common_targets(is_fbcode = is_fbcode())`.
backends/cortex_m/test/targets.bzl	Adds `is_fbcode` gating and inlines the fbcode-only unittest previously in `TARGETS`.
backends/cortex_m/test/TARGETS	Removed; content migrated into `targets.bzl`.
backends/cortex_m/test/BUCK	Now calls `define_common_targets(is_fbcode = is_fbcode())`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+        python_unittest(
+            name = "test_replace_quant_nodes",
+            srcs = [
+                "test_helpers_passes_utils.py",
+                "test_replace_quant_nodes.py",
+            ],
+            deps = [
+                "//pytorch/ao:torchao",  # @manual
+                "//caffe2:torch",
+                "//executorch/backends/cortex_m/passes:replace_quant_nodes_pass",
+                "//executorch/backends/cortex_m/ops:ops",
+            ],
+        )


+# Any targets that should be shared between fbcode and xplat must be defined in
+# targets.bzl.
+
+load("@fbsource//tools/build_defs:fbsource_utils.bzl", "is_fbcode")
+load(":targets.bzl", "define_common_targets")


+def define_common_targets(is_fbcode = False):
+    if not is_fbcode:
+        return
+
+    # @noautodeps
+
+
+
+    runtime.python_library(


…rch#21145) Summary: Chunk 7B of fbcode/executorch TARGETS->BUCK migration. 5 directories where both a TARGETS file (with extra fbcode-only rules) and a targets.bzl existed. For each: 1. Added the new fbcode-only loads from TARGETS to the top of targets.bzl (deduped against already-present loads). 2. Updated `def define_common_targets(...)` to accept `is_fbcode = False`. 3. Appended the fbcode-only TARGETS body at the end of the function inside an `if is_fbcode:` block so xplat continues to skip those rules. 4. Replaced TARGETS with a thin BUCK calling `define_common_targets(is_fbcode = is_fbcode())`. Directories migrated: - backends/cortex_m/test - examples/models/llama/fb - examples/qualcomm/oss_scripts/llama - examples/qualcomm/oss_scripts/whisper - kernels/fb/custom_ops Reviewed By: mzlee Differential Revision: D109082046

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

backends/cortex_m/test/targets.bzl:44

python_unittest here no longer sets TEST_RUNTIME_IS_NOT_OSS. backends/cortex_m/test/conftest.py checks this env var in pytest_configure() to decide whether to import torch early; without it, fbcode packaged test runs may import torch during collection/config and fail (this is why the old TARGETS rule set it). Consider restoring the env setting on this test target.

    if is_fbcode:
        python_unittest(
            name = "test_replace_quant_nodes",
            srcs = [
                "test_helpers_passes_utils.py",
                "test_replace_quant_nodes.py",
            ],

…rch#21145) Summary: Pull Request resolved: pytorch#21145 Chunk 7B of fbcode/executorch TARGETS->BUCK migration. 5 directories where both a TARGETS file (with extra fbcode-only rules) and a targets.bzl existed. For each: 1. Added the new fbcode-only loads from TARGETS to the top of targets.bzl (deduped against already-present loads). 2. Updated `def define_common_targets(...)` to accept `is_fbcode = False`. 3. Appended the fbcode-only TARGETS body at the end of the function inside an `if is_fbcode:` block so xplat continues to skip those rules. 4. Replaced TARGETS with a thin BUCK calling `define_common_targets(is_fbcode = is_fbcode())`. Directories migrated: - backends/cortex_m/test - examples/models/llama/fb - examples/qualcomm/oss_scripts/llama - examples/qualcomm/oss_scripts/whisper - kernels/fb/custom_ops Reviewed By: mzlee Differential Revision: D109082046

…rch#21145) Summary: Chunk 7B of fbcode/executorch TARGETS->BUCK migration. 5 directories where both a TARGETS file (with extra fbcode-only rules) and a targets.bzl existed. For each: 1. Added the new fbcode-only loads from TARGETS to the top of targets.bzl (deduped against already-present loads). 2. Updated `def define_common_targets(...)` to accept `is_fbcode = False`. 3. Appended the fbcode-only TARGETS body at the end of the function inside an `if is_fbcode:` block so xplat continues to skip those rules. 4. Replaced TARGETS with a thin BUCK calling `define_common_targets(is_fbcode = is_fbcode())`. Directories migrated: - backends/cortex_m/test - examples/models/llama/fb - examples/qualcomm/oss_scripts/llama - examples/qualcomm/oss_scripts/whisper - kernels/fb/custom_ops Reviewed By: mzlee Differential Revision: D109082046

…rch#21145) Summary: Pull Request resolved: pytorch#21145 Chunk 7B of fbcode/executorch TARGETS->BUCK migration. 5 directories where both a TARGETS file (with extra fbcode-only rules) and a targets.bzl existed. For each: 1. Added the new fbcode-only loads from TARGETS to the top of targets.bzl (deduped against already-present loads). 2. Updated `def define_common_targets(...)` to accept `is_fbcode = False`. 3. Appended the fbcode-only TARGETS body at the end of the function inside an `if is_fbcode:` block so xplat continues to skip those rules. 4. Replaced TARGETS with a thin BUCK calling `define_common_targets(is_fbcode = is_fbcode())`. Directories migrated: - backends/cortex_m/test - examples/models/llama/fb - examples/qualcomm/oss_scripts/llama - examples/qualcomm/oss_scripts/whisper - kernels/fb/custom_ops Reviewed By: mzlee Differential Revision: D109082046

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

backends/cortex_m/test/targets.bzl:41

The fbcode-only python_unittest target previously set TEST_RUNTIME_IS_NOT_OSS via env, but that env var is now missing. This changes how backends/cortex_m/test/conftest.py seeds randomness in fbcode runs and likely diverges from the prior behavior.

        python_unittest(
            name = "test_replace_quant_nodes",
            srcs = [

+def define_common_targets(is_fbcode = False):
+    """Defines targets that should be shared between fbcode and xplat."""
    for op in OPERATORS:


+            deps = [
+                ":runner_lib",
+                "//executorch/extension/threadpool:threadpool", # this depeneency shouldn't be needed. But it fails to build..
+            ],


+            env = {
+                "LD_LIBRARY_PATH": "$(location fbsource//third-party/qualcomm/qnn/qnn-{0}:qnn_offline_compile_libs)".format(get_qnn_library_version()),
+                # Place holder to pass the QNN_SDK_ROOT check in executorch/examples/qualcomm/utils.py
+                "QNN_SDK_ROOT": "",
+            },


Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

examples/qualcomm/oss_scripts/llama/targets.bzl:62

Spelling typo in comment: "depeneency" → "dependency".

                "//executorch/extension/threadpool:threadpool", # this depeneency shouldn't be needed. But it fails to build..

backends/cortex_m/test/targets.bzl:51

The original fbcode-only python_unittest set TEST_RUNTIME_IS_NOT_OSS based on runtime.is_oss to avoid importing torch during pytest configuration in non-OSS builds (see conftest.py usage). That env var is dropped in the new python_unittest, which can change test behavior / break collection in packaged fbcode builds.

        python_unittest(
            name = "test_replace_quant_nodes",
            srcs = [
                "test_helpers_passes_utils.py",
                "test_replace_quant_nodes.py",
            ],
            deps = [
                "//pytorch/ao:torchao",  # @manual
                "//caffe2:torch",
                "//executorch/backends/cortex_m/passes:replace_quant_nodes_pass",
                "//executorch/backends/cortex_m/ops:ops",
            ],
        )

+def define_common_targets(is_fbcode = False):
+    if not is_fbcode:
+        runtime.cxx_library(


Copilot AI review requested due to automatic review settings July 22, 2026 17:40

bigfootjon requested review from JacobSzwejbka, abhinaykukkadapu, kirklandsign, larryliu0820, psiddh and rascani as code owners July 22, 2026 17:40

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 22, 2026

Copilot started reviewing on behalf of bigfootjon July 22, 2026 17:40 View session

meta-codesync Bot added the meta-exported label Jul 22, 2026

meta-codesync Bot had a problem deploying to cadence July 22, 2026 17:40 Failure

Copilot AI reviewed Jul 22, 2026

View reviewed changes

meta-codesync Bot changed the title ~~merge fbcode-only TARGETS rules into existing targets.bzl files~~ merge fbcode-only TARGETS rules into existing targets.bzl files (#21145) Jul 23, 2026

bigfootjon force-pushed the export-D109082046 branch from fd8d811 to 723c1b7 Compare July 23, 2026 16:52

Copilot AI review requested due to automatic review settings July 23, 2026 16:52

Copilot started reviewing on behalf of bigfootjon July 23, 2026 16:52 View session

Copilot AI reviewed Jul 23, 2026

View reviewed changes

bigfootjon force-pushed the export-D109082046 branch from 723c1b7 to 6181ea1 Compare July 23, 2026 17:01

bigfootjon force-pushed the export-D109082046 branch from 6181ea1 to 9374485 Compare July 24, 2026 14:34

Copilot AI review requested due to automatic review settings July 24, 2026 14:34

Copilot started reviewing on behalf of bigfootjon July 24, 2026 14:35 View session

bigfootjon force-pushed the export-D109082046 branch from 9374485 to eecb716 Compare July 24, 2026 14:36

Copilot AI reviewed Jul 24, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 24, 2026 14:39

Copilot started reviewing on behalf of bigfootjon July 24, 2026 14:40 View session

Copilot AI reviewed Jul 24, 2026

View reviewed changes

Comment thread examples/qualcomm/oss_scripts/llama/targets.bzl

Comment on lines +10 to +12

def define_common_targets(is_fbcode = False):

if not is_fbcode:

runtime.cxx_library(

metascroy approved these changes Jul 24, 2026

View reviewed changes

meta-codesync Bot merged commit ff0f92e into pytorch:main Jul 24, 2026
197 of 199 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

merge fbcode-only TARGETS rules into existing targets.bzl files (#21145)#21145

merge fbcode-only TARGETS rules into existing targets.bzl files (#21145)#21145
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
bigfootjon:export-D109082046

bigfootjon commented Jul 22, 2026 •

edited by meta-codesync Bot

Loading

Uh oh!

pytorch-bot Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

meta-codesync Bot commented Jul 22, 2026

Uh oh!

github-actions Bot commented Jul 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

bigfootjon commented Jul 22, 2026 • edited by meta-codesync Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21145

✅ No Failures

Uh oh!

meta-codesync Bot commented Jul 22, 2026

Uh oh!

github-actions Bot commented Jul 22, 2026

This PR needs a release notes: label

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bigfootjon commented Jul 22, 2026 •

edited by meta-codesync Bot

Loading

pytorch-bot Bot commented Jul 22, 2026 •

edited

Loading

This PR needs a `release notes:` label