Skip to content

Legalize large-stride non-overlapping maxpool on U55#21284

Open
apullin wants to merge 1 commit into
pytorch:mainfrom
apullin:export-D113087299
Open

Legalize large-stride non-overlapping maxpool on U55#21284
apullin wants to merge 1 commit into
pytorch:mainfrom
apullin:export-D113087299

Conversation

@apullin

@apullin apullin commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary: Teach the Arm partitioner to recognize exact U55 large-stride non-overlapping max-pool operations as safely decomposable, without mutating the graph during partitioning. Backend preprocessing then canonicalizes value-only max_pool2d_with_indices and rewrites eligible pools into supported stride-1 reductions. This preserves the partitioner contract, keeps unrelated TOSA/VGF/U85 paths unchanged, and also covers exported MaxPool1d.

Differential Revision: D113087299

@apullin
apullin requested a review from digantdesai as a code owner July 23, 2026 15:29
@pytorch-bot

pytorch-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21284

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f1e2d98 with merge base fbd14e6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 23, 2026
@meta-codesync

meta-codesync Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@apullin has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113087299.

@meta-codesync meta-codesync Bot changed the title Legalize large-stride non-overlapping maxpool on U55 Legalize large-stride non-overlapping maxpool on U55 (#21284) Jul 24, 2026
@apullin
apullin force-pushed the export-D113087299 branch from f0e3ebf to ce6f0e2 Compare July 24, 2026 15:08
apullin added a commit to apullin/executorch that referenced this pull request Jul 24, 2026
Summary:

Teach the Arm partitioner to recognize exact U55 large-stride non-overlapping max-pool operations as safely decomposable, without mutating the graph during partitioning. Backend preprocessing then canonicalizes value-only max_pool2d_with_indices and rewrites eligible pools into supported stride-1 reductions. This preserves the partitioner contract, keeps unrelated TOSA/VGF/U85 paths unchanged, and also covers exported MaxPool1d.

Differential Revision: D113087299
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Jul 24, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary: Teach the Arm partitioner to recognize exact U55 large-stride non-overlapping max-pool operations as safely decomposable, without mutating the graph during partitioning. Backend preprocessing then canonicalizes value-only max_pool2d_with_indices and rewrites eligible pools into supported stride-1 reductions. This preserves the partitioner contract, keeps unrelated TOSA/VGF/U85 paths unchanged, and also covers exported MaxPool1d.

Differential Revision: D113087299
@meta-codesync meta-codesync Bot changed the title Legalize large-stride non-overlapping maxpool on U55 (#21284) Legalize large-stride non-overlapping maxpool on U55 Jul 24, 2026
@apullin
apullin force-pushed the export-D113087299 branch from ce6f0e2 to f1e2d98 Compare July 24, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant