gpt: add qbootctl A/B slot flags as named GPT attributes#137
Open
Royyan Zahir (royzah) wants to merge 1 commit into
Open
gpt: add qbootctl A/B slot flags as named GPT attributes#137Royyan Zahir (royzah) wants to merge 1 commit into
Royyan Zahir (royzah) wants to merge 1 commit into
Conversation
Royyan Zahir (royzah)
requested review from
Dmitry Baryshkov (lumag),
Nicolas Dechesne (ndechesne) and
Viswanath Kraleti (vkraleti)
as code owners
Royyan Zahir (royzah)
force-pushed
the
gpt-raw-attributes
branch
from
9c12f82 to
dd3dde6
Compare
Dmitry Baryshkov (lumag)
requested changes
Jul 5, 2026
| Attributes = 0x0 | ||
| # import pdb; pdb.set_trace() | ||
| # Raw --attributes (A/B slot bits) first, then the named flags below. | ||
| Attributes = int(PhyPartition[k][j].get("attributes", "0x0"), 16) |
Contributor
There was a problem hiding this comment.
I'd say, no. Please add named flags only.
Add active/successful/unbootable partition options (gen_partition --active/--successful/--unbootable) mapping to the qbootctl A/B attribute bits 50/54/55 (gpt-utils.h). ptool builds Attributes from these named flags; no raw attribute value is written.
Author
|
Dmitry Baryshkov (@lumag) |
Royyan Zahir (royzah)
force-pushed
the
gpt-raw-attributes
branch
from
dd3dde6 to
d8c1fe6
Compare
Royyan Zahir (royzah)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--attributeswas parsed only into the bootable (bit 2) and readonly (bit 60) flags, so the qbootctl A/B slot attributes were dropped and never reached the GPT.Add
active/successful/unbootableas named partition options (gen_partition--active/--successful/--unbootable), mapping to the qbootctl A/B attribute bits (gpt-utils.h: 50 / 54 / 55). ptool builds the GPT Attributes from these named flags; no raw attribute value is written.