Update qcom-preflight-checks.yml#80
Closed
Sandhya Adavikolanu (Sandhya1236) wants to merge 1 commit into
Closed
Conversation
Sandhya Adavikolanu (Sandhya1236)
force-pushed
the
Upgrade-qc-preflight-checks
branch
from
4d5dd09 to
beabf08
Compare
|
Sandhya Adavikolanu (@Sandhya1236) I see that changes in file doesn't meet with the latest qcom-preflight-checks file |
There was a problem hiding this comment.
event need to be updated from pull_request_target to pull_request
There was a problem hiding this comment.
Update the workflow name to QC Preflight Checks
| uses: qualcomm/qcom-reusable-workflows/.github/workflows/qcom-preflight-checks-reusable-workflow.yml@v2 | ||
| with: | ||
| # ✅ Preflight Checkers | ||
| repolinter: true # default: true |
There was a problem hiding this comment.
update all the parameters.
| secrets: | ||
| SEMGREP_APP_TOKEN: ${{ secrets.SEMGREP_APP_TOKEN }} No newline at end of file | ||
|
|
||
| SEMGREP_APP_TOKEN: ${{ secrets.SEMGREP_APP_TOKEN }} |
There was a problem hiding this comment.
We have removed SEMGREP_APP_TOKEN.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Sandhya Adavikolanu (Sandhya1236)
force-pushed
the
Upgrade-qc-preflight-checks
branch
from
b3c5b25 to
dc00243
Compare
Upgrade to latest v2 QC Preflight Checks Also adds optional checks defaulted to false Signed-off-by: Sandhya Adavikolanu <sadaviko@qti.qualcomm.com> Update qcom-preflight-checks.yml Upgrade to latest QC Preflight Checks Signed-off-by: Sandhya Adavikolanu <sadaviko@qti.qualcomm.com>
Sandhya Adavikolanu (Sandhya1236)
force-pushed
the
Upgrade-qc-preflight-checks
branch
from
dc00243 to
e1c40d3
Compare
|
Duplicate PR #86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades the QC Preflight Checks to the latest.
FYI there are 2 new optional checks that you may want to consider:
https://github.com/qualcomm/qcom-reusable-workflows?tab=readme-ov-file#additional-checks