fix: repair failing tests and type errors across api and shared packages#84
Open
stooit wants to merge 1 commit into
Open
fix: repair failing tests and type errors across api and shared packages#84stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
- Implement paginate() in shared (was a throwing stub) - Fix auth middleware HTTP method case-sensitivity so public routes work - Align users route to shared User.username field name - Import missing badRequest response helper in users route - Add bun-types to tsconfig types so tsc resolves Bun globals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
bun test(22 pass, 0 fail) andnpx tsc --noEmit(exit 0) fully clean. Bugs spanned both theapiandsharedpackages.Root causes & fixes
packages/shared/src/utils/pagination.ts) —paginate<T>()was a stub that threwnot implemented. Implemented slicing by(page-1)*size, withtotal,totalPages(Math.ceil),page/pageSizefields, and correct handling of out-of-range pages (emptydata) and empty input arrays.packages/api/src/middleware/auth.ts) — HTTP method comparison was case-sensitive, so the publicPOST /usersroute incorrectly required a token. Normalised the method comparison so public-route matching is casing-robust. Also resolved aCannot find name 'process'type error.packages/shared/src/types.ts+packages/api/src/routes/users.ts) — theUserfield name was inconsistent between packages; the route usedusernameagainst a differently-named field. Aligned to the field name the tests treat as authoritative.packages/api/src/routes/users.ts) —badRequestresponse helper was referenced but not imported; added the import soPOST /usersreturns 400 for missing fields.tsconfig.json— minimaltypesadjustment sotscresolves Bun globals without adding dependencies. No strictness weakened and noskipLibCheckmasking.Verification
bun test→ 22 pass, 0 failnpx tsc --noEmit→ exit 0Constraints honoured
Assumptions
page < 1,size <= 0) are not exercised by tests, so left minimal per the "fix only what tests require" constraint.🤖 Generated with autonomous agent