fix: resolve failing tests and type errors across api and shared packages#85
Open
stooit wants to merge 1 commit into
Open
fix: resolve failing tests and type errors across api and shared packages#85stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…ages - auth middleware: fix case-sensitivity bug on public HTTP method (POST) - shared types: rename User.userName to username for cross-package consistency - users route: import missing badRequest error helper - pagination: implement paginate() utility per test contract - tsconfig: add typeRoots/types so bun:test and process resolve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and eliminates all TypeScript type errors in the monorepo. After these changes
bun testreports 22 pass / 0 fail andnpx tsc --noEmitis clean (exit 0).Changes
packages/api/src/middleware/auth.ts): fixed a case-sensitivity bug — the public-methods allow-list used lowercase'post'but Hono'sc.req.methodis uppercase, soPOST /userswas incorrectly requiring a token. Also fixes theprocesstype error via the tsconfig change below.packages/shared/src/types.ts): renamed theUserfielduserName→usernameto match the canonical name used by the tests and the API routes (cross-package inconsistency).packages/api/src/routes/users.ts): added the missingbadRequestimport from../lib/errors(was used but not imported, causing a runtime + type failure). Removed a now-stale// BUG:comment.packages/shared/src/utils/pagination.ts): implemented the previously-stubbedpaginate()per the test contract — computestotal,totalPages(0 when empty), slices the correct page, and returns{ data, page, pageSize, total, totalPages }. Out-of-range pages yield an emptydataarray.tsconfig.json): addedtypeRoots+types(node,bun-types) sobun:testandprocessresolve. Packages were already installed; no new dependencies added.Verification
bun test→ 22 pass, 0 fail (37 assertions, 4 files)npx tsc --noEmit→ no errorsAssumptions
username(notuserName) is the canonical field name, as used by the tests.paginate()does not clamp negative/zero page sizes or negative pages — these cases are outside the test contract and the task scope ("fix only what the tests require"). A follow-up could add input guards if desired.