fix: repair failing tests and type errors across api and shared packages#86
Open
stooit wants to merge 1 commit into
Open
fix: repair failing tests and type errors across api and shared packages#86stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
- Implement paginate() in shared (was a throwing stub) - Fix auth middleware HTTP-method case-sensitivity so POST /users is public - Add missing badRequest import in users route - Align shared User type field to 'username' for cross-package consistency - Add types entry to tsconfig so bun:test and process resolve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 9 failing tests and all
tsc --noEmittype errors in the multi-package (Honoapi+shared) repo. After these changesbun testreports 22 pass / 0 fail andnpx tsc --noEmitexits clean.Changes
packages/shared/src/utils/pagination.ts) — implemented the previously-stubbedpaginate()(it threwnot implemented). Correctly computestotal,totalPages,page/pageSize, and the page slice; handles empty arrays, out-of-range pages, and partial last pages.packages/api/src/middleware/auth.ts) — fixed an HTTP-method case-sensitivity bug so the public-route check matches regardless of method casing, makingPOST /userspublic (no token required).packages/api/src/routes/users.ts) — added the missingbadRequestimport that was causing a runtime failure (and TS2552) on the 400-for-missing-fields path.packages/shared/src/types.ts) — aligned theUserfield name tousernamefor cross-package consistency (resolves TS2561); the field name is now canonical across both packages.typesentry sobun:testand theprocessglobal resolve without installing new dependencies.Verification
bun test→ 22 pass, 0 failnpx tsc --noEmit→ clean (exit 0)Assumptions
node_moduleswere wired up viatsconfigrather than installing anything new.Constraints honoured