fix: resolve failing tests and type errors across api and shared#87
Open
stooit wants to merge 1 commit into
Open
fix: resolve failing tests and type errors across api and shared#87stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
- implement paginate() stub in shared pagination utility - align User type field userName -> username to match consumers - fix auth middleware case-sensitivity on public POST method - switch process.env to Bun.env to avoid missing node types - add missing badRequest import in users route - add bun-types to tsconfig so bun:test and Bun globals resolve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests (7→0) and eliminates all
tsc --noEmittype errors in the bun + Hono monorepo.bun testnow reports 22 pass, 0 fail andtsc --noEmitis clean.Root causes & fixes
paginate()was an unimplemented stub throwingnot implementedpackages/shared/src/utils/pagination.tsUser.userNamedid not match consumers/tests usingusernameusernameinpackages/shared/src/types.ts"post", but Hono'sc.req.methodis uppercase — POST /users was not treated as public"POST"inpackages/api/src/middleware/auth.tsprocess.envreferenced without node types availableBun.env(equivalent at runtime)badRequestused but not imported → runtime failure on 400 pathbadRequestto the import from../lib/errorsbun:testandBunglobals unresolved bytsc"types": ["bun-types"](already installed) totsconfig.jsonVerification
bun test→ 22 pass, 0 fail (4 files)tsc --noEmit→ clean (exit 0)Scope & assumptions
bun-typeswas already present in the workspace).paginatewithsize <= 0) is not exercised by the tests and was left unchanged.