fix: resolve all failing tests in utility library#241
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: throw on division by zero instead of returning Infinity - date-utils: use Math.round for relative-day calc (fix 36h off-by-one) - string-utils: implement truncate (word-boundary + ellipsis budget) and fix wordCount for consecutive spaces - task-manager: implement remove, update, and sortBy methods - validator: allow subdomains and long TLDs in isEmail, fix isUrl for ports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously-failing tests across the TypeScript utility library. The full suite now passes 60/60 (was 44 pass / 16 fail). No test files were modified and no dependencies were added — only source fixes required by the tests.
Changes by file
src/calculator.ts—dividenow throws on division by zero instead of returningInfinity.src/date-utils.ts—formatRelativeusesMath.round(wasMath.floor) for the hours→days conversion, fixing the off-by-one at the 36-hour boundary (now "2 days ago").src/string-utils.ts— implementedtruncate(respects word boundaries, counts the ellipsis towardmaxLength, handles strings shorter than the ellipsis) and fixedwordCountto split on\s+so consecutive spaces don't inflate the count.src/task-manager.ts— implemented the missing/incompleteremove,update, andsortBymethods (sortByorders priority high>medium>low andcreatedAtoldest-first;remove/updatereturnfalsefor unknown ids).src/validator.ts—isEmailaccepts subdomains and long TLDs;isUrlaccepts URLs with ports. Also refreshed a stale JSDoc comment.Verification
bun test→ 60 pass, 0 fail, 70 expect() calls.Assumptions