fix: repair failing utility-library tests across 5 modules#246
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: divide now throws on division by zero instead of returning Infinity - string-utils: implement truncate (word-boundary + ellipsis), fix wordCount for consecutive spaces - task-manager: implement remove/update/sortBy methods per test contract - date-utils: fix off-by-one in formatRelative (Math.round day rounding) - validator: allow long TLDs in isEmail; use URL parser in isUrl to accept ports All 60 tests pass, 0 failures. No test files modified, no new dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests in the TypeScript utility library. All 60 tests now pass, 0 failures. No test files were modified and no new dependencies were added.
Fixes by module
src/calculator.ts—dividenow throwsError("Division by zero")on a zero divisor instead of returningInfinity.src/string-utils.ts— implementedtruncate(word-boundary truncation with ellipsis counting towardmaxLength, handling strings shorter than the ellipsis); fixedwordCountto collapse multiple consecutive spaces viatrim().split(/\s+/).src/task-manager.ts— implemented/completedremove,update, andsortBy(priority high→medium→low,createdAtoldest-first) per the test contract.src/date-utils.ts— fixed off-by-one informatRelativeby rounding days withMath.roundinstead ofMath.floor(36h now correctly reads "2 days ago").src/validator.ts—isEmailnow allows long TLDs (e.g..museum);isUrluses theURLparser so hosts with ports (e.g.http://localhost:3000) validate.Verification
bun test→ 60 pass / 0 fail.Assumptions
formatRelativeday rounding usesMath.round, consistent with the test expectation at the 36h boundary.isUrlaccepts onlyhttp:/https:protocols (matches existing test coverage).