fix: repair failing tests across utility library#247
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: divide throws on division by zero instead of returning Infinity - string-utils: fix wordCount for consecutive spaces, implement truncate - task-manager: implement remove/update/sortBy methods - date-utils: fix formatRelative off-by-one rounding - validator: isEmail accepts long TLDs, isUrl accepts ports - refresh stale JSDoc comments describing fixed bugs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously-failing tests across the utility library. Test suite now passes 60/60 (was 44/60), with no changes to test files and no new dependencies.
Changes
src/calculator.ts—dividenow throwsError("Division by zero")on a zero divisor instead of returningInfinity.src/string-utils.ts—wordCounthandles consecutive/leading/trailing whitespace viatrim().split(/\s+/);truncateimplemented.src/task-manager.ts— implemented the missing/incompleteTaskManagermethods (remove / update / sortBy).src/date-utils.ts— correctedformatRelativeoff-by-one rounding so relative durations bucket correctly.src/validator.ts—isEmailaccepts long TLDs (e.g..museum);isUrlaccepts explicit ports (e.g.http://localhost:3000).BUG:JSDoc comments that described the now-fixed behaviour.Verification
bun test→ 60 pass / 0 fail (70 assertions).Assumptions
isUrl/isEmailrelaxations are intentional per the tests; the review noted these widen accepted input but flagged no correctness regression within tested scope.