-
Notifications
You must be signed in to change notification settings - Fork 561
feat(pulsar): support distributed indexing #6561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
miton18
wants to merge
6
commits into
quickwit-oss:main
Choose a base branch
from
CleverCloud:feat/pulsar-distributed-indexing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1026d0d
feat(pulsar): support distributed indexing
miton18 97b03e0
fix(pulsar): refresh partition position on failover handoff; fix rest…
miton18 c326bdd
fix(pulsar): resync partition position on every failover (re)gain
miton18 d765a6c
fix(pulsar): gate failover resync to distributed sources; document me…
miton18 ab1cb8a
fix(pulsar): only suffix the consumer name for distributed sources
miton18 5c7267b
fix(pulsar): ack broker to committed position on failover resync
miton18 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allowing Pulsar in this multi-pipeline allow-list changes the
/indexes/{index}/sourcespath so the existingtest_create_source_with_bad_configcase inquickwit-serve/src/index_api/rest_handler.rsno longer fails config validation fornum_pipelines: 2; it proceeds to the metastore lookup for the missingmy-indexinstead, so that test still asserting a 400 with the old Kafka/PubSub-only error will fail. Please update or remove that bad-config case with this feature enabled.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 97b03e0. Updated
test_create_source_with_bad_configto assert the multi-pipeline rejection using akinesissource (still gated) plus the new error-message wording.