Build lambda ARM64 artifact on edge builds to main#6569
Conversation
Aligns the lambda build trigger with the docker/merge jobs so main pushes produce a fresh lambda binary for edge images, instead of only tag-triggered releases.
fulmicoton-dd
force-pushed
the
paul-masurel/build-lambda-on-main-edge
branch
from
a523c70 to
e412951
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e412951577
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if: github.ref_type == 'tag' | ||
| # Build a fresh lambda for tag-triggered releases and edge builds on main. | ||
| # workflow_dispatch and other branches fall back to the pinned URL in build.rs. | ||
| if: github.ref_type == 'tag' || (github.ref_type == 'branch' && github.ref == 'refs/heads/main') |
There was a problem hiding this comment.
For workflow_dispatch runs launched from main, GitHub still sets github.ref_type to branch and github.ref to refs/heads/main, so this condition runs build-lambda even though the adjacent comment says manual dispatches should fall back to the pinned URL. Because docker now needs this job, a manually triggered Docker publish from main becomes blocked by the ARM64 lambda build and will skip entirely if that extra build fails; add a github.event_name == 'push' guard to the main-branch side if only push edge builds should build the fresh lambda.
Useful? React with 👍 / 👎.
| push: | ||
| branches: | ||
| # Triggers an edge build, gated behind manual approval of the "production" environment. | ||
| - main |
There was a problem hiding this comment.
This workflow no longer matches pushes to release-0.9, while the same change also removes the only v0.9.0-rc metadata tag rule and I found no remaining release-0.9/v0.9.0-rc publisher elsewhere in the repo. Any push that previously refreshed the RC Docker image from that branch will now produce no image at all, so keep the branch/tag rule unless decommissioning that release stream is intentional.
Useful? React with 👍 / 👎.
2 participants
Summary
build-lambdapreviously only ran on tag-triggered releases (if: github.ref_type == 'tag'); pushes tomainfell back to the pinned lambda URL and never produced a fresh binary.docker/mergeso edge builds onmainalso build and package a fresh lambda ARM64 artifact.ASSET_VERSIONextraction to handle branch pushes (previously only stripped therefs/tags/prefix, leavingrefs/heads/mainunchanged); branch builds now getedge-<short-sha>.Test plan
maintriggersBuild Lambda ARM64and it completes successfully