Skip to content

feat: single role assignment in admin member menus#1667

Merged
rohanchkrabrty merged 1 commit into
fix-admin-issuesfrom
fix-admin-single-role
Jun 3, 2026
Merged

feat: single role assignment in admin member menus#1667
rohanchkrabrty merged 1 commit into
fix-admin-issuesfrom
fix-admin-single-role

Conversation

@rohanchkrabrty
Copy link
Copy Markdown
Contributor

Summary

  • Replace the assign-role dialog with inline role options in the org members and project members action menus — selecting a role opens an "Update role" confirmation AlertDialog
  • Adopt the sdk AlertDialog.createHandle pattern for the update-role dialogs instead of useState-driven open state
  • Add a destructive "Remove" action (new DeleteIcon + danger color token) to both member menus, dropping the trailing ... from the labels
  • Guard against removing an org's last member using the loaded row count (backend doesn't send total_count)
  • Remove the now-unused project assign-role.tsx

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Jun 2, 2026 10:20am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 2, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 879487eb-28f8-46b2-b082-c12bd3ddb728

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 26813548015

Coverage remained the same at 43.06%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 37887
Covered Lines: 16314
Line Coverage: 43.06%
Coverage Strength: 12.08 hits per line

💛 - Coveralls

@rohanchkrabrty rohanchkrabrty merged commit 91c5df2 into fix-admin-issues Jun 3, 2026
8 checks passed
@rohanchkrabrty rohanchkrabrty deleted the fix-admin-single-role branch June 3, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants