fix(spicedb): migrate batch check to the stable bulk permissions API#1777
Open
AmanGIT07 wants to merge 2 commits into
Open
fix(spicedb): migrate batch check to the stable bulk permissions API#1777AmanGIT07 wants to merge 2 commits into
AmanGIT07 wants to merge 2 commits into
Conversation
BulkCheckPermission is deprecated in authzed-go and slated for removal. The stable CheckBulkPermissions API has the same shape and is available in the pinned version, so this is a pure rename. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesSpiceDB bulk permission checks
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 29744337323Coverage remained the same at 46.11%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Nothing uses the experimental service after the batch check migration, so hold a plain client. Same options, no other change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
3 tasks
rohilsurana
reviewed
Jul 21, 2026
| func (r *RelationRepository) BatchCheck(ctx context.Context, relations []relation.Relation) ([]relation.CheckPair, error) { | ||
| result := make([]relation.CheckPair, len(relations)) | ||
| items := make([]*authzedpb.BulkCheckPermissionRequestItem, 0, len(relations)) | ||
| items := make([]*authzedpb.CheckBulkPermissionsRequestItem, 0, len(relations)) |
Member
There was a problem hiding this comment.
Have we tested this with currently default set version of spicedb in the docker as well as k8s charts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the SpiceDB integration off the experimental API surface. The batch check migrates from the deprecated
BulkCheckPermissionto the stableCheckBulkPermissions, and the client no longer requests experimental APIs since nothing uses them afterwards.Changes
internal/store/spicedb/relation_repository.go(BatchCheck): rename the request, item, and pair types and the client method to their stable names. Same fields, same accessors, no logic change.internal/store/spicedb/spicedb.go: construct the client withauthzed.NewClientand hold*authzed.Clientinstead of the experimental variant. Same dial options.Technical Details
The stable API is available in the already-pinned
authzed-goversion; no dependency change. The stable response guarantees pairs in request order, which the result indexing relies on.Test Plan
NewClient