Sponsors page - #110
Conversation
|
@tjtanjin could you review this PR ? |
|
Hey @mushroomgenie, thanks for putting this together! The overall structure and dark-theme design look good, and splitting the page into focused components makes sense. Some issues to address before merging:
Thanks again for contributing! Once these are addressed, the page should be in much better shape to ship! |
|
@tjtanjin I made the changes, can you review the PR and see if it can be merged ? |
|
Hey @mushroomgenie and @tjtanjin! Sorry for late reply, this PR was already merged and is live but had a few UI related notes and fix suggestions.
Most of the FAQ items are also missing the content and also opening and closing these FAQ accordions is causing some "jumpiness" in the UI. My guess would be that its animating height: auto or there is a Framer Motion related issue like nested layout animations or something causing this. Should be a fairly easy fix Also a more general note: looks like the text isn't resizing on smaller screens, for example the h1 stays at 60px along the way but on mobile it's set to 48px in the original Figma designs. I think this is a general typography issue and would need a separate task, issue is not related to this specific PR or page. |
Description
This PR implements the sponsors page based on the design that was given in the issue. A new page is created with a separate endpoint and the page is broken down into components based on the design. Since the design was just a templated, the data too was imported as is from the Figma file.
Closes #106
What change does this PR introduce?
Please select the relevant option(s).
What is the proposed approach?
Created a new page in the
pagesfolder. Added the route/sponsors. Created new components that are being used in the newly generated page file.Checklist: