Skip to content

Specialize interface file types. #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
viliml wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Specialize interface file types. #707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/interface.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export interface UploadProps
accept?: string | AcceptConfig;
multiple?: boolean;
onBatchStart?: (
fileList: { file: RcFile; parsedFile: Exclude<BeforeUploadFileType, boolean> }[],
fileList: { file: RcFile; parsedFile: RcFile }[],
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In AjaxUploader.tsx, if beforeUpload returns false, processFile returns a ParsedFileInfo object where parsedFile is null (line 212). Since onBatchStart is called with the unfiltered fileList (line 185), parsedFile can indeed be null at runtime. Typing parsedFile strictly as RcFile without allowing null can lead to runtime errors or TypeScript compilation failures in consuming applications that use strictNullChecks. We should update the type to RcFile | null to accurately reflect this possibility.

Suggested change
fileList: { file: RcFile; parsedFile: RcFile }[],
fileList: { file: RcFile; parsedFile: RcFile | null }[],

) => void;
onStart?: (file: RcFile) => void;
onError?: (error: Error, ret: Record<string, unknown>, file: RcFile) => void;
Expand Down Expand Up @@ -60,7 +60,7 @@ export type UploadRequestMethod = 'POST' | 'PUT' | 'PATCH' | 'post' | 'put' | 'p

export type UploadRequestHeader = Record<string, string>;

export type UploadRequestFile = Exclude<BeforeUploadFileType, File | boolean> | RcFile;
export type UploadRequestFile = RcFile;

export interface UploadRequestError extends Error {
status?: number;
Expand Down