Skip to content

Drop RCT_EXPORT_METHOD from RCTImageEditingManager (#57773) #57773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christophpurrer wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −12
Open

Drop RCT_EXPORT_METHOD from RCTImageEditingManager (#57773) #57773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions packages/react-native/Libraries/Image/RCTImageEditingManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,20 +38,22 @@ @implementation RCTImageEditingManager
* be scaled down to `displaySize` rather than `size`.
* All units are in px (not points).
*/
RCT_EXPORT_METHOD(
cropImage : (NSURLRequest *)imageRequest cropData : (JS::NativeImageEditor::Options &)cropData successCallback : (
RCTResponseSenderBlock)successCallback errorCallback : (RCTResponseSenderBlock)errorCallback)
- (void)cropImage:(NSString *)imageRequestString
cropData:(JS::NativeImageEditor::Options &)cropData
successCallback:(RCTResponseSenderBlock)successCallback
errorCallback:(RCTResponseSenderBlock)errorCallback
{
NSURLRequest *imageRequest = [RCTConvert NSURLRequest:imageRequestString];

CGRect rect = {
[RCTConvert CGPoint:@{
@"x" : @(cropData.offset().x()),
@"y" : @(cropData.offset().y()),
}],
[RCTConvert CGSize:@{
@"width" : @(cropData.size().width()),
@"height" : @(cropData.size().height()),
}]
};
[RCTConvert CGPoint:@{
@"x" : @(cropData.offset().x()),
@"y" : @(cropData.offset().y()),
}],
[RCTConvert CGSize:@{
@"width" : @(cropData.size().width()),
@"height" : @(cropData.size().height()),
}]};

// We must keep a copy of cropData so that we can access data from it at a later time
JS::NativeImageEditor::Options cropDataCopy = cropData;
Expand Down
Loading