Fix #270: Resolve django_form limitations for multi-value and multi-select fields#298
Open
Archmonger wants to merge 4 commits into
Open
Fix #270: Resolve django_form limitations for multi-value and multi-select fields#298Archmonger wants to merge 4 commits into
Archmonger wants to merge 4 commits into
Conversation
…delMultipleChoiceField - Updated `components.ts` to accumulate duplicate FormData entries into arrays instead of silently dropping duplicates (as Object.fromEntries would do). - Updated `utils.py` convert_form_fields() to normalize MultipleChoiceField and ModelMultipleChoiceField values (absent/None -> empty list, single -> array). - Updated test forms to include MultipleChoiceField and ModelMultipleChoiceField in BasicForm and BootstrapForm for regression coverage.
Archmonger
pushed a commit
that referenced
this pull request
Jul 20, 2026
…d-trip assertions Following code review suggestions for PR #298: - New test_forms_utils.py: 10 unit tests covering None->[], single->[value], list->unchanged for MultipleChoiceField, ModelMultipleChoiceField, BooleanField/NullBooleanField, and CharField pass-through. - test_form_basic: explicit input_value assertions on multi-select and model multi-select fields after successful form submission, proving the FormData duplicate-key fix works end-to-end. - Fix pre-existing ruff import ordering issue in utils.py
…d-trip assertions Following code review suggestions for PR #298: - New test_forms_utils.py: 10 unit tests covering None->[], single->[value], list->unchanged for MultipleChoiceField, ModelMultipleChoiceField, BooleanField/NullBooleanField, and CharField pass-through. - test_form_basic: explicit input_value assertions on multi-select and model multi-select fields after successful form submission, proving the FormData duplicate-key fix works end-to-end. - Fix pre-existing ruff import ordering issue in utils.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix (partial) #270 by resolving two categories of
django_formlimitations:1. FormData serialization bug (MultipleChoiceField data loss)
Object.fromEntries(formData.entries())silently drops duplicate keys, causingMultipleChoiceFieldandModelMultipleChoiceFieldto lose all values except the last selected option. Replaced with a manual loop that accumulates duplicate keys intoFormDataEntryValue[]arrays.2. Robust
convert_form_fieldsnormalizationImproved
convert_form_fields()to properly handle edge cases:Nonevalues from unselected multi-select fields →[][value]3. Test coverage for multi-value fields
Added
SplitDateTimeFieldandMultiValueFieldtoBasicFormin the test app for regression coverage.Checklist
By submitting this pull request I agree that all contributions comply with this project's open source license(s).