feature: provide reason when it fails, dont remove newlines in log output#6
Open
adietish wants to merge 1 commit into
Open
feature: provide reason when it fails, dont remove newlines in log output#6adietish wants to merge 1 commit into
adietish wants to merge 1 commit into
Conversation
…tput Signed-off-by: Andre Dietisheim <adietish@redhat.com>
adietish
force-pushed
the
proper_error_output
branch
from
b76860b to
bbb310c
Compare
adietish
requested review from
RomanNikitenko,
rgrunber and
sbouchet
as code owners
rgrunber
reviewed
May 28, 2026
| return 0 | ||
| else | ||
| # fail | ||
| log $(oc exec -n ${DEVWORKSPACE_NS} ${podName} -c ${mainContainerName} -- cat /idea-server/std.out) |
Member
There was a problem hiding this comment.
Isn't the point of log that all these message can be controlled (and silenced if wanted ?). With echo they are forcibly printed.
Collaborator
There was a problem hiding this comment.
agree. the default mode is not intended to log too many.
if failures, the list of tests is displayed ( images/devfiles ) so you can tweak the accoring files, then re-run with -v that will verbose all the logs.
Contributor
Author
There was a problem hiding this comment.
you're absolutely right. I oversaw that I completely skipped the ability to show/hide output with this patch. Reworking it. 🤦♂️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.