Skip to content

Pin kustomize version in dockerfile for CI#1163

Open
varshab1210 wants to merge 2 commits into
redhat-developer:masterfrom
varshab1210:ci-pin-kustomize-version
Open

Pin kustomize version in dockerfile for CI#1163
varshab1210 wants to merge 2 commits into
redhat-developer:masterfrom
varshab1210:ci-pin-kustomize-version

Conversation

@varshab1210
Copy link
Copy Markdown
Member

What type of PR is this?

/kind failing-test

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Signed-off-by: Varsha B <vab@redhat.com>
@openshift-ci openshift-ci Bot added the kind/failing-test Categorizes issue or PR as related to a frequently failing test. label Jun 3, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: cd2e7daa-c21b-4f8f-a522-d5bb8b6251d3

📥 Commits

Reviewing files that changed from the base of the PR and between c9076fd and 6e26327.

📒 Files selected for processing (1)
  • openshift-ci/build-root/Dockerfile
🚧 Files skipped from review as they are similar to previous changes (1)
  • openshift-ci/build-root/Dockerfile

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Kustomize installation is now configurable via a version parameter (default: 5.7.0), improving build flexibility and making it easier to pin or update the tool.
    • Installation flow refined to consistently install the specified Kustomize version and maintain the same runtime layout and cleanup behavior as before.

Walkthrough

The Dockerfile now declares a KUSTOMIZE_VERSION build argument (default 5.7.0) and passes it to the Kustomize install script in the image build RUN step, preserving the install location and cleanup.

Changes

Kustomize Version Parameterization

Layer / File(s) Summary
Kustomize version parameterization
openshift-ci/build-root/Dockerfile
A KUSTOMIZE_VERSION build argument is declared with default 5.7.0. The Kustomize installation RUN command is updated to fetch install_kustomize.sh quietly and pass KUSTOMIZE_VERSION into the script while installing to /usr/local/bin and removing the temp script.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is minimal and lacks substantive details, but it contains the PR kind label (failing-test) which is related to the changeset context. Consider providing more details about why the kustomize version needs to be pinned, what issue it addresses, and testing performed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: pinning the kustomize version in the Dockerfile for CI purposes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from AdamSaleh and anandf June 3, 2026 18:22
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign naveena-058 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@openshift-ci/build-root/Dockerfile`:
- Line 6: The ARG KUSTOMIZE_VERSION default is wrong and missing the leading
"v": update the Dockerfile's ARG KUSTOMIZE_VERSION to the exact version expected
by the e2e tests ("v5.8.1") so the install script uses the matching semver
string; ensure the value includes the "v" prefix and replace the current "5.7.0"
token with "v5.8.1" wherever ARG KUSTOMIZE_VERSION is defined or referenced.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 3da1e714-bcc2-43c9-a97f-62c8632a9a76

📥 Commits

Reviewing files that changed from the base of the PR and between d4b8418 and c9076fd.

📒 Files selected for processing (1)
  • openshift-ci/build-root/Dockerfile

FROM quay.io/devtools_gitops/go-toolset:1.25.5
USER root

ARG KUSTOMIZE_VERSION=5.7.0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Version mismatch with e2e test expectations and missing 'v' prefix.

The default version 5.7.0 conflicts with the e2e test requirement in test/openshift/e2e/ginkgo/parallel/1-031_validate_toolchain_test.go:85-88, which expects v5.8.1. Additionally, the version lacks the v prefix that previous defaults used (e.g., v4.5.7 in hack/non-olm-install/README.md). This format inconsistency may cause the install script to fail.

🔧 Proposed fix
-ARG KUSTOMIZE_VERSION=5.7.0
+ARG KUSTOMIZE_VERSION=v5.8.1
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ARG KUSTOMIZE_VERSION=5.7.0
ARG KUSTOMIZE_VERSION=v5.8.1
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@openshift-ci/build-root/Dockerfile` at line 6, The ARG KUSTOMIZE_VERSION
default is wrong and missing the leading "v": update the Dockerfile's ARG
KUSTOMIZE_VERSION to the exact version expected by the e2e tests ("v5.8.1") so
the install script uses the matching semver string; ensure the value includes
the "v" prefix and replace the current "5.7.0" token with "v5.8.1" wherever ARG
KUSTOMIZE_VERSION is defined or referenced.

@varshab1210
Copy link
Copy Markdown
Member Author

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 4, 2026

@varshab1210: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-kuttl-parallel 6e26327 link false /test v4.14-kuttl-parallel
ci/prow/v4.19-kuttl-parallel 6e26327 link true /test v4.19-kuttl-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/failing-test Categorizes issue or PR as related to a frequently failing test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant