Pin kustomize version in dockerfile for CI#1163
Conversation
Signed-off-by: Varsha B <vab@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Dockerfile now declares a ChangesKustomize Version Parameterization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@openshift-ci/build-root/Dockerfile`:
- Line 6: The ARG KUSTOMIZE_VERSION default is wrong and missing the leading
"v": update the Dockerfile's ARG KUSTOMIZE_VERSION to the exact version expected
by the e2e tests ("v5.8.1") so the install script uses the matching semver
string; ensure the value includes the "v" prefix and replace the current "5.7.0"
token with "v5.8.1" wherever ARG KUSTOMIZE_VERSION is defined or referenced.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: 3da1e714-bcc2-43c9-a97f-62c8632a9a76
📒 Files selected for processing (1)
openshift-ci/build-root/Dockerfile
| FROM quay.io/devtools_gitops/go-toolset:1.25.5 | ||
| USER root | ||
|
|
||
| ARG KUSTOMIZE_VERSION=5.7.0 |
There was a problem hiding this comment.
Version mismatch with e2e test expectations and missing 'v' prefix.
The default version 5.7.0 conflicts with the e2e test requirement in test/openshift/e2e/ginkgo/parallel/1-031_validate_toolchain_test.go:85-88, which expects v5.8.1. Additionally, the version lacks the v prefix that previous defaults used (e.g., v4.5.7 in hack/non-olm-install/README.md). This format inconsistency may cause the install script to fail.
🔧 Proposed fix
-ARG KUSTOMIZE_VERSION=5.7.0
+ARG KUSTOMIZE_VERSION=v5.8.1📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ARG KUSTOMIZE_VERSION=5.7.0 | |
| ARG KUSTOMIZE_VERSION=v5.8.1 |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@openshift-ci/build-root/Dockerfile` at line 6, The ARG KUSTOMIZE_VERSION
default is wrong and missing the leading "v": update the Dockerfile's ARG
KUSTOMIZE_VERSION to the exact version expected by the e2e tests ("v5.8.1") so
the install script uses the matching semver string; ensure the value includes
the "v" prefix and replace the current "5.7.0" token with "v5.8.1" wherever ARG
KUSTOMIZE_VERSION is defined or referenced.
|
/retest |
|
@varshab1210: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind failing-test
What does this PR do / why we need it:
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer: