Skip to content

[master] update ginkgo version in makefile#1168

Open
openshift-cherrypick-robot wants to merge 1 commit into
redhat-developer:masterfrom
openshift-cherrypick-robot:cherry-pick-1167-to-master
Open

[master] update ginkgo version in makefile#1168
openshift-cherrypick-robot wants to merge 1 commit into
redhat-developer:masterfrom
openshift-cherrypick-robot:cherry-pick-1167-to-master

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #1167

/assign svghadi

Signed-off-by: Varsha B <vab@redhat.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wtam2018 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 5, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: ef1660dd-4d19-41ba-9640-24b523e1a19a

📥 Commits

Reviewing files that changed from the base of the PR and between ffc55c6 and afdfda0.

📒 Files selected for processing (1)
  • Makefile

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated build dependencies to the latest available patch version.

Walkthrough

The Makefile ginkgo target was updated to install Ginkgo v2.29.0 instead of v2.28.1 via the build tool installation mechanism.

Changes

Build Tool Dependencies

Layer / File(s) Summary
Ginkgo v2 version update
Makefile
Ginkgo v2 CLI version bumped from v2.28.1 to v2.29.0 in the ginkgo build target.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: updating the Ginkgo version in the Makefile from v2.28.1 to v2.29.0.
Description check ✅ Passed The description is related to the changeset as it documents that this is a cherry-pick of a related PR that makes the same change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 5, 2026

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@svghadi
Copy link
Copy Markdown
Member

svghadi commented Jun 5, 2026

/ok-to-test

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 5, 2026

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.19-kuttl-parallel afdfda0 link true /test v4.19-kuttl-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants